Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting ActivityHandler, ActivityTableRow and ActivityTable into functional components #5442

Conversation

Aminehassou
Copy link
Contributor

@Aminehassou Aminehassou commented Jun 27, 2023

With reference to #5393

What this PR does

Converts activity_handler.jsx, activity_table_row.jsx and activity_table.jsx into functional components
Affected Pages:

  • /courses/[institution_id]/[course_id]/activity/[chosen_page_name] (for activity_handler.jsx)
  • /recent-activity/[chosen_page_name] (for activity_table_row.jsx and activity_table.jsx)

Videos

Before activity_handler.jsx

before.refactor.ActivityHandler.mp4

After activity_handler.jsx

after.refactor.ActivityHandler.mp4

Before activity_table_row.jsx and activity_table.jsx

before.refactor.ActivityTableRow.and.Activity.Table.mp4

After activity_table_row.jsx and activity_table.jsx

after.refactor.ActivityTableRow.and.Activity.Table.mp4

@Aminehassou Aminehassou changed the title Converting ActivityHandler into functional component Converting ActivityHandler, ActivityTableRow and ActivityTable into functional components Jun 28, 2023
@Aminehassou Aminehassou marked this pull request as ready for review June 28, 2023 04:05
@ragesoss ragesoss merged commit 5869f48 into WikiEducationFoundation:master Jul 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants