Optimized 'Training' Page for Mobile Responsiveness #5559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you add screenshots for the 'before'? |
|
@ragesoss I have Updated the Screenshot related to 'Before'. |
ragesoss
reviewed
Jan 5, 2024
| @@ -17,6 +17,8 @@ | |||
| padding 10px 11px | |||
| width 50px | |||
| height 50px | |||
| position absolute | |||
| right 0px | |||
There was a problem hiding this comment.
Do these changes have any effect on the non-mobile layout?
There was a problem hiding this comment.
I tested it and see that they cancel each other out; 'absolute' introduces space to the right of the box holding the arrow icon, but right 0 removes it again. LGTM
|
This looks much better, and I don't notice any problems or regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This will make the 'Training Page' Responsive for mobile view.
Fixes issue #5558
Screenshots
Before:
After: