Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored 'campaign_ores_plot.jsx' from Class component to Functional component #5619

Conversation

PR4NJ41
Copy link
Contributor

@PR4NJ41 PR4NJ41 commented Feb 3, 2024

What this PR does

Refactored 'campaign_ores_plot.jsx' from Class component to Functional component

Preview

Before:

Before.mov

After:

After.mov

@om-chauhan1
Copy link
Contributor

om-chauhan1 commented Feb 3, 2024

Hello @PR4NJ41 , this component is already refactored in an existing pull request.
#5606

@PR4NJ41
Copy link
Contributor Author

PR4NJ41 commented Feb 3, 2024

Hii @om-chauhan1,
This Component is different from the one refactored in #5606. This is campaign_ores_plot & the one in other PR is course_ores_plot.jsx. If you look closely the file names are different. You can also check in commits that these 2 files are located at different path.

@om-chauhan1
Copy link
Contributor

Oh sorry for the oversight. You are right

@ragesoss ragesoss merged commit 735a872 into WikiEducationFoundation:master Feb 26, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants