Eliminating Redundant Clicks on Submit Button in Article Finder #5626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks like the 'before' video has a problem; it's not rendering for me. |
|
@ragesoss Here is the 'before' video. Reuploaded_before.mp4 |
|
@ragesoss I am also able to reproduce this on https://outreachdashboard.wmflabs.org/ 
|
|
@ragesoss Here is the link of the video in case the preview video still does not renders. |
|
Great, thanks. I'm trying to catch up on PR review and hope to get to it later this week. |
|
It looks like this has a conflict with the PR that I merged that converts ArticleFinder to a functional component. |
|
@ragesoss I have fixed merged conflicts. Thank You! |
ragesoss
reviewed
Feb 15, 2024
app/assets/javascripts/components/article_finder/article_finder.jsx
Outdated
Show resolved
Hide resolved
|
@ragesoss I have updated the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This pull request addresses an issue in the Article Finder page, where users were encountering many errors by submitting the search query multiple times. Previously, clicking the submit button more than once would lead to errors.
To resolve this issue, I have implemented a set of conditions that disable the submit button after the user clicks it for the first time. The button remains disabled until the search results for the entered query are fully loaded. Additionally, the button is re-enabled after the query is completed.
This enhancement not only prevents the occurrence of errors associated with multiple submit button clicks but also provides a smoother user experience by ensuring that the button is only active when it is appropriate to initiate a new search.
Preview
Before:
Before.mov
After:
After.mp4