Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed State Persistance of Quality Checklist #5637

Conversation

PR4NJ41
Copy link
Contributor

@PR4NJ41 PR4NJ41 commented Feb 10, 2024

What this PR does

This PR resolves State persistance issue of checkboxes in Quality Checklist.
Fixes issue #5636

Preview

Before:

Before.mov

After:

After.mp4

@PR4NJ41
Copy link
Contributor Author

PR4NJ41 commented Feb 12, 2024

@ragesoss This PR is ready for Review. Please review it.

@ragesoss
Copy link
Member

Thanks! I'll test this soon, but it's worth noting that this will only solve persistence during the lifetime of the React app, so refreshing or navigating away will still result in loss of state. That's okay, though, I don't think this is a feature worth trying to persist on the backend, so this approach is good enough for me.

@PR4NJ41
Copy link
Contributor Author

PR4NJ41 commented Feb 16, 2024

@ragesoss Yes, I thought of adding it to the backend but this way it makes more sense as most links on that page opens in newtab. And to review, the user can close the dialog box then make changes using in other tab and return and reopen box to check mark and move forward.

@ragesoss ragesoss merged commit 2f32728 into WikiEducationFoundation:master Feb 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants