Fixing warnings when starting Guard
#5651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragesoss
reviewed
Feb 13, 2024
|
Please include a link to the sidekiq-cron changelog and a summary of what changed between these versions, so we know what to look out for in terms of bugs or regressions that this update might introduce. |
|
This Update in v1.8.0 release of |
|
Also, the specs which are failing are flaky & aren't related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Bumped
sidekiq-cronfrom v1.7.0 to v1.12.0.This will fix warnings caused by it.
Addresses issue #5645
Screenshots
Before:
After:
