Add: Reducer Test for feedback.js #5683
Conversation
| @@ -15,12 +15,22 @@ export default function feedback(state = initialState, action) { | |||
| } | |||
| case POST_USER_FEEDBACK: { | |||
| const newState = { ...state }; | |||
| newState[action.assignmentId].custom.push({ message: action.feedback, messageId: action.messageId, userId: action.userId }); | |||
| const assignmentId = action.assignmentId; | |||
There was a problem hiding this comment.
The code for these actions is pretty complex and it's hard to reason about how it's supposed to work. Could you add a comment illustrating the typical structure of the feedback state? That would make the code easier to think about.
There was a problem hiding this comment.
@ragesoss I add comments to explain the structure of the feedback state.
- The original method uses push() to add an object to an array within an object in a state variable. It directly mutates the custom array inside the newState[action.assignmentId] object. I use the spread operator and object destructuring to create a new object with the updated custom array. It does not mutate the existing state but instead creates a new object with the updated custom array.
- Previous code uses splice(), which mutates the original array by removing elements and potentially adding new ones. I use filter() method to create a new array containing only the elements that pass the test implemented by the provided function. It does not modify the original array.
Hope this explains the revision clearly. Thank you.
|
Great! Have you tested the UI flow of adding a feedback comment and viewing an existing one? Since this also changes the reducer in addition to adding tests, I want to double-check that we're not introducing a regression. |
|
@ragesoss The UI appears to be working fine on my end. I've noticed that the CI build has failed. Could you please inform me about the error? I'm not sure why it failed. |
|
That CI failure is unrelated (and is already fixed on the main branch). Can you post a video of before and after of using the feedback UI feature? |
|
@ragesoss I've just realized that I was searching for the wrong UI element. I've created a new course but can't seem to find the assignment and feedback options. Could you please guide me on where to locate the feedback UI feature? |
What this PR does
This PR revises the feedback.js file. It creates a new custom array for newState[action.assignmentId], including the existing items (if any) and the new feedback item. This ensures that the state is not mutated directly, avoiding the "Cannot add property 0, object is not extensible" error. This PR also adds a test file for reducer feedback.js
Screenshots
Before:
After:
#2082