Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the layout of "subject specific guides" block in Timeline. #5712

Merged
merged 6 commits into from Mar 20, 2024

Conversation

PR4NJ41
Copy link
Contributor

@PR4NJ41 PR4NJ41 commented Mar 19, 2024

What this PR does

Improved the layout of "subject specific guides" block in Timeline.

This is the other method which adds div with classname on block creation. This is only added to the handout section. Hence this will be added to only newly created courses.

fixes #5707

Screenshots

Before:

Before
Screenshot 2024-03-21 at 1 35 51 AM
Screenshot 2024-03-20 at 4 12 04 AM

After:

After
Screenshot 2024-03-21 at 1 35 34 AM
Screenshot 2024-03-20 at 4 12 12 AM

@PR4NJ41
Copy link
Contributor Author

PR4NJ41 commented Mar 19, 2024

@ragesoss Please review this.

@PR4NJ41
Copy link
Contributor Author

PR4NJ41 commented Mar 19, 2024

@ragesoss this might create unwanted styling changes. Also Some styling like align center of the edit menu won't work.

Before:
Screenshot 2024-03-20 at 4 12 04 AM

After:
Screenshot 2024-03-20 at 4 12 12 AM

@ragesoss
Copy link
Member

Hmm... I actually like the bullet styling better. I don't think there is much if any custom content that uses the center formatting. I'm okay with some minor changes, as long as it doesn't break anything in a noticeable way.

@PR4NJ41
Copy link
Contributor Author

PR4NJ41 commented Mar 20, 2024

I don't think there is much if any custom content that uses the center formatting.

By center I mean the formatting as shown in the video.

Changes.mp4

@PR4NJ41
Copy link
Contributor Author

PR4NJ41 commented Mar 20, 2024

@ragesoss I have made the suggested changes. Please review. Thanks!

@ragesoss
Copy link
Member

By center I mean the formatting as shown in the video.

That's what I thought you meant. I think this is fine. I think you can remove the aligncenter center option by editing the tinyMCE config in text_area_input.jsx.

@PR4NJ41
Copy link
Contributor Author

PR4NJ41 commented Mar 20, 2024

@ragesoss I have made the changes.

@ragesoss
Copy link
Member

Please update the screenshots to illustrate all changes (including the change to the text editor), and then this should be ready to go.

@PR4NJ41
Copy link
Contributor Author

PR4NJ41 commented Mar 20, 2024

@ragesoss I have updated the screenshots. Thanks!

@ragesoss ragesoss merged commit 5e4bfe2 into WikiEducationFoundation:master Mar 20, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve layout of "subject specific guides" block in Timeline
2 participants