Minor UI/UX Improvements #5719
Merged
Minor UI/UX Improvements #5719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragesoss
reviewed
Mar 25, 2024
| const NoLabelStyle = { | ||
| display: 'inline', | ||
| fontWeight: 'normal', | ||
| color: '#6a6a6a' |
There was a problem hiding this comment.
Why not implement this in the stylesheet?
There was a problem hiding this comment.
Because these styles are used for a very specific use case. Here, its used to override default styles inherited from the form > label CSS. If you want I can add it as a CSS class but it will be hardly used again.
There was a problem hiding this comment.
I would prefer this to be done in CSS here.
|
Can you include a before/after comparison? |
Its a very minor thing but adds to the overall user experience. With these changes, the user can select the radio button using the label. In this video notice first the production behavior and then the updated changes. screen-recording-2024-03-26-22.29.webm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
I have created this PR to fix some minor UI/UX bugs that I might come across while working on other tasks.
Changes
You can Merge this PR now or wait till the PR has some more significant commits.