Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 5693 - Training Data in Editors CSV #5723

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

prathamVaidya
Copy link
Contributor

What this PR does

Fixes #5693

It populates the training data in the editor's CSV file.

Added three fields in the last:

  • completed_training_modules_count
  • assigned_training_modules_count
  • completed_training_modules

image

@prathamVaidya
Copy link
Contributor Author

@ragesoss I am getting "Class has too many lines" error. I am not sure how can I reduce lines in this class as nothing seems to be inheritable and no methods can be separated further.

image

@ragesoss
Copy link
Member

You can add an exception for this file in .rubocop.yml, or you could find a way to extract some of the code in that file to another file. I think most of the code that doesn't have to do directly with the user and their progress (like getting the array of exercise modules vs non-exercise modules) would make sense to live in its own file, perhaps implemented via delegation in course.rb similar to how that file uses :trained_students_manager.

@ragesoss
Copy link
Member

Looks like a failing test is connected to your change.

@prathamVaidya
Copy link
Contributor Author

Looks like a failing test is connected to your change.

Fixed it

@prathamVaidya
Copy link
Contributor Author

Finally, No errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editors data CSV for a course should include data about training modules completed.
2 participants