Converted upload_viewer.jsx to functional component and used i18n for string literals #5753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmitJoki
reviewed
Apr 18, 2024
| } | ||
| let categoriesList = []; | ||
| let categories; | ||
| forEach(get(metadata, 'categories', []), (category) => { |
There was a problem hiding this comment.
I think we can slowly migrate away from using lodash functions for things which we can natively do in JS.
forEach(get(metadata, 'categories', []), (category) => {
would be just
(metadata.categories ?? []).forEach((category) => {
om-chauhan1
force-pushed
the
RefactorReactClassComponentsStream16
branch
from
3083970
to
1743ad2
Compare
om-chauhan1
force-pushed
the
RefactorReactClassComponentsStream16
branch
from
1743ad2
to
7788004
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR converted the upload_viewer.jsx from class to functional component and used i18n for string literals.
Videos
Before:
After: