-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding start/end times to courses #951
Merged
ragesoss
merged 32 commits into
WikiEducationFoundation:master
from
MusikAnimal:start-end-times
Sep 30, 2016
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
403bfe1
Migrations to change date columns to datetime in courses table
MusikAnimal 170e7a8
Update course model and comments in course_spec
MusikAnimal 4ce4ffd
Fix changed behavior of legacy course end dates
ragesoss b5cecac
Fix RevisionsController spec for course end as datetime
ragesoss 309c4f9
Update CourseMeetingsManager to handle datetime timeline dates
ragesoss 3bfad7a
Fix last few broken specs for datetime migration
ragesoss 6cbd6f0
Fix date comparisons in course_creation_spec
MusikAnimal 062c107
Update DatePicker to include a hour/min dropdowns, make everything in…
MusikAnimal d395dde
UI cleanup, define whether to show time control in models
MusikAnimal 19eaf2f
Add before_save in Course to set end times to end_of_day
MusikAnimal 6666beb
Basic frontend for DatePicker w/time picker in place
MusikAnimal eb11b1a
Address some CR concerns
MusikAnimal 1378232
Attempt to get use_start_and_end_times to show up in CourseCreator
MusikAnimal c1c4643
use_start_and_end_times now being passed to CourseCreator
MusikAnimal df9e45b
CourseCreator fixes to work with new date/time picker
MusikAnimal 648ba1f
Move initial start/end times to CourseStore
MusikAnimal 39f8adf
Fix state driven value in DatePicker
MusikAnimal a8eebbf
Working date/time picker for course creation
MusikAnimal 687d588
Make sure CourseDateUtils.isDateValid() returns a boolean
ragesoss 4cac571
Update unit tests for new end-of-day end dates
ragesoss d288d93
Remove default dates from CourseStore
MusikAnimal 2982784
Don't validate YYYY-MM-DD format as they type so that DayPicker will …
MusikAnimal c5b035f
use RegExp.prototype.test() in CourseDateUtils to force a boolean ret…
MusikAnimal d9ed8b6
attempt to make Travis green
MusikAnimal 2b9ae07
Fix course_cloning_spec
ragesoss 91e978b
Prevent multiple course submissions
ragesoss 5f6178a
More handling of the course save flow
ragesoss 56d18f0
Fix another spec
ragesoss 233f9eb
assert times are saved properly in open_course_creation_spec
MusikAnimal ae44b38
test BasicCourse revisions are within start/end times
MusikAnimal 3e3f2b9
test default start/end times are set properly when changing course types
MusikAnimal cece0b9
CR concerns
MusikAnimal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Along with datepicker unit tests, it would be great to use
React.PropTypes.shape
to validate the shape of date_props more precisely. Not strictly necessary as part of this PR, but it would be nice.