Implemented simple image download retry #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1058,53 +1065,85 @@ def generateImageDump(config={}, other={}, images=[], start='', session=None): | |||
| if not os.path.isdir(imagepath): | |||
| print 'Creating "%s" directory' % (imagepath) | |||
| os.makedirs(imagepath) | |||
|
|
|||
|
|
|||
| maxseconds = 100 # max seconds to wait in a single sleeping | |||
There was a problem hiding this comment.
Should we put this as something that the user can configure, or should we enforce this as a hard limit?
There was a problem hiding this comment.
It's currently a fixed value for the XML part as well.
I've only followed that. The number of retries is configurable though.
|
|
||
| while not completed: | ||
| if retried > 0 and retried < maxretries: | ||
| wait = increment * retried < maxseconds and increment * \ |
There was a problem hiding this comment.
Place the code in one line and the comments should precede the code.
|
Forgot github updates pull requests automatically. The later commits were not intended for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a crash on this point before due to a server error, so I figured a simple retry would help.