Add GitHub Actions workflow #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first stage of migrating CI to GitHub Actions. The goal for the CI overall is to compile scala via the update script and run the test script upon merge to develop. Eventually this will integrate wth a GitFlow release process.
rajadain
approved these changes
May 15, 2024
| set -x | ||
|
|
||
| ./scripts/server >gh_output.txt 2>&1 & | ||
| sleep 15 |
There was a problem hiding this comment.
Consider adding a comment here along the lines of:
# Wait for server to start up before testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is the first stage of migrating CI to GitHub Actions. The goal for the CI overall is to compile scala via the update script and run the test script upon merge to develop. Eventually this will integrate with a GitFlow release process.
Connects #97
Demo
Notes
serverscript, when run on its own, will run indefinitely within CI if not ran as a background process. Simply running the script with an&appended at the end will still produce output, which prevents it from running as a background process: instead, it would be a suspended background process. Redirecting output and error to an output file (>gh_output.txt 2>&1) allows for it to correctly run as a background process but then raises the issue of not providing insights into possible failures. Line 9 of thecitestscript can be uncommented in order to review the output/errors of running theserverscript.serverscript to run successfully, repository secrets forAWS_ACCESS_KEY_ID,AWS_SECRET_ACCESS_KEY, andAWS_REGIONhave been created within the repo. These correspond to the AWS access key and secret access key for thegithub-actionsAWS user. This information is stored in 1Password under theDataHub GitHub User Accessentry.CHANGELOG.mdwill be updated when ready to merge in order to prevent possible merge conflicts.Testing Instructions
test/*branch off of this branch and push up to GitHub; confirm GHA runs and completes successfully.initials/*branch off this branch and push up to GitHub; confirm GHA does NOT run.