Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PA DEP 2021 Contract #3392

Open
21 of 30 tasks
rajadain opened this issue May 7, 2021 · 0 comments
Open
21 of 30 tasks

PA DEP 2021 Contract #3392

rajadain opened this issue May 7, 2021 · 0 comments
Assignees
Labels
PA DEP Funding Source: Pennsylvania Department of Environment Protection

Comments

@rajadain
Copy link
Member

rajadain commented May 7, 2021

Tasks for the PA DEP 2021 Contract:

Task 1: Ingest New NLCD Layers

Enhancements

Task 2: Ingest High Resolution NHD+ Streams

Bugs

Enhancements

Task 3: Add Drainage Area Drawing

  • Add /draw/drainage-area/ endpoints to the geoprocessing API for drawing point based and stream based drainage areas
    • These should be Celery task based endpoints, like the analyze and model ones
    • These should return the drainage area, and the source point or stream selected
    • These should raise proper errors on bad input or if there's no streams in the given polygon
    • These should return dummy areas of interest until the Drexel / ANS API is ready
  • Add draw tools for those two techniques
    • These should follow the implementation of RWD
    • The returned point or selected stream should be added to the map in addition to the area of interest
    • Reseting the drawing or selecting a new area of interest should remove all the additional layers
  • Integrate with Drexel / ANS API #3558 5️⃣
    • Once the Drexel / ANS API for drainage area calculation is up, integrate the /draw/draiange-area/ endpoints with it
    • Add additional error handling as appropriate
  • Add Drainage Area Analysis Back-end #3553 2️⃣
    • This should take the area of interest, and the land use distribution from the Drexel / ANS API
    • This should run GWLF-E for the HUC-12 the shape is in, and scale the results to the area of interest based on its land use distribution
  • Add Drainage Area Analyze View #3557 3️⃣
    • This should only be visible if the area of interest is a Drainage Area
    • This should trigger the /analyze/drainage-area/ endpoint made above
    • This should show the results of the drainage area in Hydrology and Water Quality tabs, a-la GWLF-E
      • Verify this with BME

Clarifications

  • Remove Water Quality Analyze Tab, Rename Drainage Area Analysis to "Loads"
    • The Loads analysis should still only be visible if the area of interest was a drainage area
  • Rename Drainage Area to Hillslope Catchment and follow the language updates here: https://docs.google.com/document/d/1-O56QcVxKMqlW-26MnDm5HkYI71yMzQ80GQiZVV6oTE/
  • Replace the current tables in the Loads analysis with a single table, which is similar to the Water Quality Loads table:
    image
    with the following changes:
    • Add an Area column that shows the area of the land cover type
    • Remove the non-land cover type rows (Farm Animals, Stream Bank Erosion, Subsurface Flow, Point Sources, Septic Systems)
    • Add a totals row at the bottom that sums all columns

Addons

@rajadain rajadain added the PA DEP Funding Source: Pennsylvania Department of Environment Protection label May 7, 2021
@rajadain rajadain self-assigned this May 7, 2021
rajadain added a commit that referenced this issue Jul 7, 2022
rajadain added a commit that referenced this issue Jan 25, 2023
Until all the tasks in #3392 are completed, disable the drainage area drawing so it doesn't open the door to folks using it on production.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PA DEP Funding Source: Pennsylvania Department of Environment Protection
Projects
None yet
Development

No branches or pull requests

1 participant