-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tooltip to inactive layers #2055
Conversation
In both staging and your branch screenshot above, I find the contrast between active/inactive to be a bit hard to distinguish. Can we make the active layer names darker (or fully black)? |
I did make them a shade darker, but I suspect @jfrankl wouldn't want full black. Jeff, what do you think about reusing #273238 (header shade)? |
I agree with @ajrobbins. This is an improvement, but it's now a little harder to tell the difference between active and inactive. Maybe we need the 👁️ and 🚫 👁 ? |
Reusing #273238 sounds good.
…On Wed, Jul 19, 2017 at 1:18 PM, Casey Cesari ***@***.***> wrote:
I agree with @ajrobbins <https://github.com/ajrobbins>. This is an
improvement, but it's now a little harder to tell the difference between
active and inactive. Maybe we need the 👁 and 🚫 👁 ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2055 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABud9Po7763e3iXfMKWpu_dWxSo3G-UWks5sPjpPgaJpZM4Ob8K0>
.
--
Jeff Frankl, User Experience Designer
Azavea | 990 Spring Garden Street, 5th Floor, Philadelphia, PA
Web azavea.com | Blog azavea.com/blogs | Twitter @azavea
<http://twitter.com>
|
Both the active and inactive Grey colors are darkened so they are more visible.
1dc23af
to
0713ab4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. It's much more legible, and easier to differentiate between active and inactive layers.
Overview
Adds a tooltip to deactivated layers in the layer picker and also makes active and inactive layers a shade darker.
Connects #1797
Connects #1581
Connects #1725
Demo
Staging
![screenshot from 2017-07-18 17 18 58](https://user-images.githubusercontent.com/1014341/28340295-34f1bd6c-6bdd-11e7-89a7-daf9905051ad.png)
The Branch
![screenshot from 2017-07-18 17 13 53](https://user-images.githubusercontent.com/1014341/28340281-25a068a4-6bdd-11e7-9d04-1c7281e55b30.png)
Notes
I got sign off from @jfrankl in #1725, but please comment on the outcome.
Testing Instructions