Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip to inactive layers #2055

Merged
merged 2 commits into from
Jul 19, 2017
Merged

Add tooltip to inactive layers #2055

merged 2 commits into from
Jul 19, 2017

Conversation

mmcfarland
Copy link
Contributor

Overview

Adds a tooltip to deactivated layers in the layer picker and also makes active and inactive layers a shade darker.

Connects #1797
Connects #1581
Connects #1725

Demo

Staging
screenshot from 2017-07-18 17 18 58

The Branch
screenshot from 2017-07-18 17 13 53

Notes

I got sign off from @jfrankl in #1725, but please comment on the outcome.

Testing Instructions

  • After bundling, pan the map far to the Atlantic which will disable the Delaware stream layer title.
  • Ensure that hovering displays the tooltip
  • Ensure that hovering over active layers does not show a tooltip
  • The styles should be darker and more legible.

@mmcfarland mmcfarland changed the title Mjm/deactivated layer Add tooltip to inactive layers Jul 18, 2017
@ajrobbins
Copy link

In both staging and your branch screenshot above, I find the contrast between active/inactive to be a bit hard to distinguish. Can we make the active layer names darker (or fully black)?

@mmcfarland
Copy link
Contributor Author

Can we make the active layer names darker (or fully black)?

I did make them a shade darker, but I suspect @jfrankl wouldn't want full black. Jeff, what do you think about reusing #273238 (header shade)?

@caseycesari
Copy link
Member

I agree with @ajrobbins. This is an improvement, but it's now a little harder to tell the difference between active and inactive. Maybe we need the 👁️ and 🚫 👁 ?

@jfrankl
Copy link
Contributor

jfrankl commented Jul 19, 2017 via email

Both the active and inactive Grey colors are darkened so they are more
visible.
@mmcfarland
Copy link
Contributor Author

Updated with ui-primary. Such contrast:

screenshot from 2017-07-19 14 37 27

Copy link
Member

@caseycesari caseycesari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It's much more legible, and easier to differentiate between active and inactive layers.

@mmcfarland mmcfarland merged commit 3a72252 into develop Jul 19, 2017
@mmcfarland mmcfarland deleted the mjm/deactivated-layer branch July 19, 2017 18:54
@rajadain rajadain mentioned this pull request Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants