HydroShare Update Resource #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When POSTing new files to /export/hydroshare?project=XX for a project that has already been exported, we now update the files for it in HydroShare and send back the updated Hydro- ShareResource entity with an updated exported_at date.
This will likely be superseded by styling and UI changes in #2574, but serves the purpose of exercising the new backend code and demonstrating how updates are expected to execute.
rajadain
force-pushed
the
tt/hydroshare-export-update-resource
branch
from
00b26fd
to
06234d1
Compare
|
Taking a look now! |
arottersman
approved these changes
Jan 2, 2018
src/mmw/apps/export/views.py
Outdated
| # POST existing resource updates it | ||
| if hsresource and request.method == 'POST': | ||
| # Update files | ||
| files = params.get('files', []) |
There was a problem hiding this comment.
Could this be moved out to a helper function and called from L144? If we're creating a file for the first time it will pass on trying to delete it, so it should have the same behavior in both cases.
There was a problem hiding this comment.
Effectively same behavior, but an extra API call per file. Still, the similarities are too much to ignore. I'll abstract it into a helper function.
|
Just posted a refactor in a927bd0 that creates a helper class for HydroShare and abstracts the |
|
Nice, going to test this out one more time. |
|
+1, still working. |
|
Thanks for taking a look! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds the ability to re-export to HydroShare. We cannot edit the title, abstract, or keyword list using hs_restclient after the resource has been first created, so this deletes any existing files from the new payload and re-exports them. If the resource has any files outside of the list specified in the request body, they will be unaffected.
Connects #2573
Demo
Notes
Regarding versioning, I tested adding it:
which created and returned a new resource, which in the UI linked to the old one:
and the old resource was updated with a link to the new one:
This old resource could then no longer be edited from the HydroShare UI. I'm not sure if this behavior is desirable, so I'm not adding it at this point (otherwise we'd get a new resource every time any change is made to the project in MMW), but we can revisit it in the future.
Testing Instructions