Export GMS File In HydroShare Resource #2585
Conversation
|
I merged #2580 and haven't started taking a look at this yet, so feel free to squash and rebase on |
arottersman
force-pushed
the
arr/hydroshare-gms
branch
from
f510623
to
9188035
Compare
For mapshed projects include a GMS file for each scenario * Named like scenario_this-is-a-scenario-name.gms * List of mapshed data is passed from client; gms file is created on the server before adding to hydroshare
arottersman
force-pushed
the
arr/hydroshare-gms
branch
from
9188035
to
36b7416
Compare
| @@ -12,6 +13,7 @@ | |||
| from django.conf import settings | |||
|
|
|||
| from apps.user.models import HydroShareToken | |||
| from apps.modeling.tasks import to_gms_file | |||
There was a problem hiding this comment.
Importing this here feels like it couples this too much with modeling. Some of this will be refactored in #2584, but I think it would be a better idea to use to_gms_file in views.py, and use it to construct a {name: 'scenario_xyz.gms', contents: '...'} object that is added to the files array given to hs.add_files. Does this make sense?
There was a problem hiding this comment.
Yes, but it won't be as clean as described.to_gms_file returns a file, and shouldn't be passed as contents to hs.add_files which will try to rewrite it via StringIO.
There was a problem hiding this comment.
Ah right. Very well, we'll tackle that later.
src/mmw/js/src/core/modals/views.js
Outdated
| @@ -19,6 +19,7 @@ var _ = require('lodash'), | |||
| modalIframeTmpl = require('./templates/iframeModal.html'), | |||
| vizerUrls = require('../settings').get('vizer_urls'), | |||
|
|
|||
| GWLFE = 'gwlfe', | |||
There was a problem hiding this comment.
Can we import this from modeling/models? I'd prefer not defining the same constant in two places.
There was a problem hiding this comment.
This is in core which is usually agnostic to the other directories (which import it). I think instead it's time to move the model constants out into core/utils. We reference them in analyze, modeling, and now here.
I'll add a commit.
|
Added a commit to move the model constants into |
|
Taking another look. |
We were using the model package constants in analyze, modeling and core/modals, but they were declared in modeling. Move them to core utils so they are available throughout the client.
arottersman
force-pushed
the
arr/hydroshare-gms
branch
from
9c5323c
to
45da769
Compare
|
Thanks for the review! |
For mapshed projects include a GMS file
for each scenario
scenario_this-is-a-scenario-name.gmsfile is created on the server before adding to
hydroshare
Connects #2577
Demo
Project with exported GMS files
Testing Instructions