Show Subbasin Huc-12s On Map #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 18, 2018 13:49
* Add a map feature group layer to show all the huc-12s in a subbasin modeled shape. * Each layer in the feature group is a HUC-12 geometry that highlights on hover. On click an 'active' attribute is set on the corresponding SubbasinDetail; this is not used yet.
* Instead of reading the active huc12 in the huc12-level
view from an option, read it from state on the `subbasins`
collection's models ('active'). This way clicking on the
map and clicking a row on the table both navigate you to
huc12-level view.
* Hovering on the map should highlight the row on the table
Keep the highlighting in sync between the table and the map shapes.
* When a subbasin huc12 is selected, make it gold and fit the map bounds to it. * Don't apply hover styling to it when it is selected * Still apply hover styling to the other huc12s, but make sure they get sent back to the back of the layer stack so the active layer appears on top
added 3 commits
April 19, 2018 12:17
* If the subbasin details are available before the model results have finished, do not allow the user to select a shape on the map. * If the subbasin results finish before the subbasin details are available, listen to the details collection for changes, so that set up can be completed when the details are ready. While waiting, display the huc12 name as a placeholder '--' and don't do any map behavior related to hovering over the table.
Fix a bug whereby we were overwriting the `gis_data` attribute on a project with the subbasin mapshed results. The subbasin mapshed results are not proper GMS files, and should not be available for download.
* When toggling between analyze, monitor and model, clear the subbasin map state where appropriate and set it back when returning. Make sure layers stay in their appropriate order (ie active subbasin should always be on top of everything) * When exiting the modeling view, clear the subbasin results from the map.
arottersman
changed the title
|
Taking a look now. |
|
Are the HUC-12 boundaries supposed to be this color? It's hard to differentiate it from the water in the underlying basemap:
|
rajadain
approved these changes
Apr 19, 2018
|
Made #2789 for the follow up. |
|
Thanks for making that follow up, and for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add the huc-12 subbasin shapes to the map. They have two-way interactivity: you can active their hover state by hovering over them on the map or on the huc-12 totals table. You can select one via clicking the map or clicking their row in the huc12 totals table.
Connects #2651
Demo
[ ignore the error on the analyze page in this gif. It isn't related. ]
Testing Instructions
./scripts/bundle.shSome things to try: