Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Observations Layer tab data loading #2797

Merged
merged 1 commit into from
Apr 25, 2018
Merged

Conversation

rajadain
Copy link
Member

Overview

This bug was introduced in 02b5a7f. Allows the Observations Layer tab to load historical data again.

Connects #2761

Notes

The historical data loading still often fails because of server issues.

Testing Instructions

  • Check out this branch and bundle
  • Open the app and the javascript console
  • Go to the observations tab in the layer picker and enable a layer
  • Click an observation point and click through to Historical Data
  • Ensure there are no javascript errors in the console (disregard any server side errors)

This bug was introduced in 02b5a7f. Allows the Observations
Layer tab to load historical data again.
@kellyi
Copy link
Contributor

kellyi commented Apr 25, 2018

Setting this up!

@kellyi
Copy link
Contributor

kellyi commented Apr 25, 2018

Was able to get River Gauge historical data to load:

screen shot 2018-04-25 at 11 11 16 am

The other observation layers seemed to send back 500 errors from the server -- not sure whether those originate from MMW or from the observations service?

Copy link
Contributor

@kellyi kellyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me. I assume we're not dealing with the server side errors here, but if we have some control over those we should consider making a card to fix them.

@kellyi kellyi assigned rajadain and unassigned kellyi Apr 25, 2018
@rajadain
Copy link
Member Author

Correct: we are not touching the server side at all here, just the client side. We may move away from the backend service used for this in the future, so I'm not going to make a card for the intermittent failures right now. It is a known issue.

Thanks for taking a look!

@rajadain rajadain merged commit 90868f5 into develop Apr 25, 2018
@rajadain rajadain deleted the tt/fix-observations-tab branch April 25, 2018 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants