Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Conversion: MapShed #3033

Merged
merged 9 commits into from
Nov 28, 2018
Merged

Unit Conversion: MapShed #3033

merged 9 commits into from
Nov 28, 2018

Conversation

rajadain
Copy link
Member

Overview

Implements Unit Conversion for MapShed.

Connects #3024

Demo

image

image

image

image

image

image

image

image

image

image

Notes

They had asked to use US short ton for Sediments, since its values are so much larger than Nitrogen and Phosphorus which are better represented in pounds. However, some of our tables (particularly the summary table in Water Quality result tab in MapShed) put the units in the first column for each row, which could not resolve different cells having different units, so I've kept them all as pounds for now. This can be addressed at a later stage.

Testing Instructions

  • Checkout this branch and bundle --debug
  • Login and set your units as "US Customary"
  • Make a MapShed project for a well known area. On Staging, also make a MapShed project using the same well known area.
  • As you go through MapShed, ensure that US Customary units are used throughout: in the results, in the compare tab, in manual entry, in land cover entry, in conservation practices modifications.
  • Compare with the project on staging and ensure the conversions make sense
  • Go to settings and change your units to Metric. Re-open the project. Ensure all results and your modifications are appropriately converted.

@rajadain rajadain added NSF Funding Source: National Science Foundation Unit Conversion labels Nov 27, 2018
Copy link
Member

@caseycesari caseycesari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice job.

@caseycesari caseycesari assigned rajadain and unassigned caseycesari Nov 28, 2018
@rajadain rajadain merged commit 834c40d into develop Nov 28, 2018
@rajadain rajadain deleted the tt/unit-conversion-mapshed branch November 28, 2018 16:21
@rajadain
Copy link
Member Author

Thanks for taking a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NSF Funding Source: National Science Foundation Unit Conversion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants