Upgrade Middleware for Production

[rajadain]

Overview

This was missed in 3a73743, and has caused Staging and Production deploys to fail. Also fixes the health-check endpoint which was failing.

Connects #3130

Demo

http://civicci01.internal.azavea.com/view/mmw/job/model-my-watershed-packer-app-and-worker/1165/console

and

> http --print HhBb :8000/health-check/
GET /health-check/ HTTP/1.1
Accept: */*
Accept-Encoding: gzip, deflate
Connection: keep-alive
Host: localhost:8000
User-Agent: HTTPie/1.0.2



HTTP/1.1 200 OK
Connection: keep-alive
Content-Encoding: gzip
Content-Type: application/json
Date: Fri, 26 Jul 2019 18:19:44 GMT
Server: nginx
Transfer-Encoding: chunked
Vary: Accept-Encoding

{
    "caches": [
        {
            "default": {
                "ok": true
            }
        }
    ],
    "databases": [
        {
            "default": {
                "ok": true
            }
        }
    ]
}

Testing Instructions

• Check out this branch
• Go to :8000/health-check/
  • Ensure it works correctly
• Go to :8000/health-check (no trailing slash)
  • Ensure you get a ConnectionError, indicating that the middlewares are being skipped correctly (otherwise there is one that appends the trailing slash)

[jwalgran]

Looks good to me

[rbreslow]

I get a 301 when I http --print HhBb :8000/health-check, but this looks good. 👍

[rajadain]

Hmm, so do I actually. The 301 redirects to:

Location: http://localhost/health-check/

so it drops the port and adds a slash. I think that is happening because CommonMIddleware (which adds the trailing slash) preceeds BypassMiddleware, so that still runs.

model-my-watershed/src/mmw/mmw/settings/base.py

Lines 258 to 271 in 63a746d

	# MIDDLEWARE CONFIGURATION
	# See: https://docs.djangoproject.com/en/1.11/topics/http/middleware/
	MIDDLEWARE = (
	# Default Django middleware.
	'corsheaders.middleware.CorsMiddleware',
	'django.middleware.common.CommonMiddleware',
	'mmw.middleware.BypassMiddleware',
	'django.contrib.sessions.middleware.SessionMiddleware',
	'django.middleware.csrf.CsrfViewMiddleware',
	'django.contrib.auth.middleware.AuthenticationMiddleware',
	'django.contrib.messages.middleware.MessageMiddleware',
	'apps.user.middleware.ItsiAuthenticationMiddleware',
	)
	# END MIDDLEWARE CONFIGURATION

But the health check is working correctly, which is the main issue. So I'll take that approval and run with it.