Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ansible from 2.4.4.0 to 2.6.18 in /deployment #3144

Merged
merged 2 commits into from Aug 14, 2019

Conversation

@dependabot @github
Copy link
Contributor

dependabot bot commented on behalf of github Aug 13, 2019

Bumps ansible from 2.4.4.0 to 2.6.18.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [ansible](https://github.com/ansible/community) from 2.4.4.0 to 2.6.18.
- [Release notes](https://github.com/ansible/community/releases)
- [Commits](https://github.com/ansible/community/commits)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies label Aug 13, 2019
@caseycesari

This comment has been minimized.

Copy link
Member

caseycesari commented Aug 13, 2019

I tested this out, and I believe it's safe to merge as-is. Here's what I did:

  • Ran the model-my-watershed-packer-tiler job. It ran successfully.
  • Ran the model-my-watershed-packer-app-and-worker. It ran successfully.
  • Examined the output of both of those job runs for any new deprecation warnings. I don't think these need to be addressed at the moment:
    • [DEPRECATION WARNING]: Using tests as filters is deprecated. Instead of using `result|changed` use `result is changed`. This feature will be removed in version 2.9. . Given that this feature will still be supported in 2.8.x, and that some of the roles (azavea.java for instance) need to be updated and not the direct MMW code, I thought this was okay to leave for now.
    • [DEPRECATION WARNING]: The use of 'include' for tasks has been deprecated. Use 'import_tasks' for static inclusions or 'include_tasks' for dynamic inclusions. This feature will be removed in a future release. Deprecated, but not going to be removed yet.
    • [DEPRECATION WARNING]: include is kept for backwards compatibility but usage is discouraged. The module documentation details page may explain more about this rationale. This feature will be removed in a future release. Related to the previous message. Confirms that include will be kept around for now.
  • Tested out staging after the images created from this branch were deployed. No issues found.
  • Reviewed the porting guide for 2.5 and 2.6 for any breaking changes that would impact MMW, but didn't see anything.
  • Upgraded my local Ansible to 2.6.18 and reprovisioned all of the VMs. I didn't run into any issues.
@hectcastro

This comment has been minimized.

Copy link
Contributor

hectcastro commented Aug 13, 2019

The testing process looks good. The only concern I have is that this PR diff doesn't contain the associated change to mmw.json:

"sudo pip install ansible==2.4.4.0",

If that wasn't tested as part of this, then I don't think any of the AMI builds used the upgraded version of Ansible.

@hectcastro hectcastro self-requested a review Aug 13, 2019
Needs to be in-sync with the deployment requirements file.
@caseycesari

This comment has been minimized.

Copy link
Member

caseycesari commented Aug 13, 2019

@hectcastro I actually made that change before doing any of the testing. I was using a local branch to test so I didn't accidentally screw this one up. Pushed up a commit to this branch to update that file.

Copy link
Contributor

hectcastro left a comment

👍

Copy link
Contributor

hectcastro left a comment

👍

@caseycesari caseycesari merged commit 296c366 into develop Aug 14, 2019
@caseycesari caseycesari deleted the dependabot/pip/deployment/ansible-2.6.18 branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.