Add Timeout Environment Variable, Use Throughout, Up to 200s #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the latest version of the geoprocessing service, we can now override certain settings with environment variables. We had set the timeout to 160s in the last version, but that is not enough, so we up it to 200s. In the future, we can set this simply by setting this value, without needing a full re-deploy of the geoprocessing service.
The new MMW_GEOPROCESSING_TIMEOUT variable is wired in to the back-end and the front-end, so all the timeouts are now always in sync, and can be changed from one central place.
Running Mapshed now takes longer because of the Hi Res streams. Since running Mapshed for a large shape (~HUC-8), for multiple shapes (sub-basin), and running multiple GWLF-Es all take a few minutes, that messaging is consolidated.
rajadain
added
the
PA DEP
|
With CI passing, in the interest of time, I'm going to merge this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We noticed that despite #3448 and WikiWatershed/mmw-geoprocessing#98, which fixed timeouts for the Schuylkill HUC-8 in development, we were still seeing timeouts on Staging. This could be because of multiple users requesting runs at the same time. This PR further ups that to 200s.
Updates to mmw-geoprocessing 5.2.0, which exposes environment variable overrides for certain settings. See WikiWatershed/mmw-geoprocessing#100.
Adds an
MMW_GEOPROCESSING_TIMEOUTenvironment variable that is used in themmw-geoprocessingservice definition to set a timeout value of 200 seconds, up from the 120 baked in.Also wires in that environment variable to be used for Celery, and the front-end, up from the 120 seconds as previously configured. Also updates messaging to be more appropriate.
Connects #3446
Testing Instructions
Since this was already working in development and not staging, the true test is on staging.