Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The longer the timeouts are, the more the likelihood of our resources being caught up and overloaded. To prevent that, we pick a short timeout. But, if the timeout is too short, then the expected requests will not complete.
Previously, we had set the default timeout to 1 minute in 26771b9 as part of #87. This was to allow the subbasin query for the Schuylkill HUC-8, which has 61 HUC-12s inside it, to complete. When running the geoprocessing service natively, using
./scripts/server
, this would take ~13s:When running inside the Worker VM, with fewer resources than in native environments, it would take a little longer, ~20s:
With the usage of NHD Hi Res streams as of WikiWatershed/model-my-watershed#3432, the expected times have increased significantly, beyond the 1 minute timeout.
By upping the limit to 2 minutes, we ensure that the Schuylkill HUC-8's subbasin query completes successfully.
Connects WikiWatershed/model-my-watershed#3446
Demo
Schuylkill HUC-8 Subbasin with NHD Hi Res Streams, running natively:
Schuylkill HUC-8 Subbasin with NHD Hi Res Streams, running in the Worker VM:
Testing Instructions
./scripts/setup
mmw-geoprocessing/scripts/benchmark
Lines 61 to 68 in 49a84f2
./scripts/server
./scripts/benchmark --subbasin