Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for multiple underscores in SRAT results #3607

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Account for multiple underscores in SRAT results #3607

merged 2 commits into from
Jan 23, 2024

Conversation

rajadain
Copy link
Member

@rajadain rajadain commented Jan 19, 2024 •
edited by rachelekm
Loading

Overview

SRAT results for HUC-12s were broken because of multiple underscores in the results. This fixes it.

Closes #3602

Demo

image

Testing Instructions

  • Check out this branch and ./scripts/debugcelery.sh
  • Go to http://localhost:8000/
  • Select the City of Philadelphia HUC-12
  • Select Watershed Multi-Year Model
  • Switch to Water Quality tab
  • Click on "View subbasin attenuated results"
    • Ensure the modeling succeeds

@rachelekm rachelekm self-requested a review January 23, 2024 17:30
@rachelekm rachelekm self-assigned this Jan 23, 2024
rachelekm
rachelekm approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@rachelekm rachelekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success! Confirming modeling succeeds for HUC-12

@rajadain rajadain merged commit 29b41fc into develop Jan 23, 2024
@rajadain rajadain deleted the tt/3602/fix-subbasin-modeling-huc12s branch January 23, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachelekm rachelekm rachelekm approved these changes

Assignees

@rachelekm rachelekm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subbasin Modeling Failing for some HUC-12s
2 participants
@rajadain @rachelekm