Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Python 3 #72

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Upgrade to Python 3 #72

wants to merge 7 commits into from

Conversation

rajadain
Copy link
Member

Overview

Upgrades the code to Python 3.

Connects #71
Connects #16
Connects WikiWatershed/model-my-watershed#3165

Testing Instructions

  • Check out this branch and run pipenv install --dev
  • Run the tests with pipenv run nosetests --verbosity=2
    • Ensure they pass

And update .gitignore correspondingly
Some of these long floating point results are not stable,
so we check them up to 7 digits of precision to ensure that
they work.
The round() function was reimplemented in Python 3 to round to
the nearest even number, instead of the higher one, in case of
half-way points. Apparently this produces more accurate results
over large data points, which would otherwise skew higher than
expected.

For more details, see:

  - https://docs.python.org/3/whatsnew/3.0.html#builtins
  - https://stackoverflow.com/q/10825926/6995854
@rajadain rajadain requested review from emilyhu0106 and removed request for jwalgran November 15, 2021 22:19
@rajadain rajadain assigned emilyhu0106 and unassigned jwalgran Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants