IW-3384 | Add support for global Lua modules #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for global Lua modules in UCP Scribunto, as done before for app in Wikia/app#4550. Unfortunately Scribunto doesn't offer an extension point here, so the relevant functionality has to be inlined. The actual business logic of fetching the content of global modules is handled by the UCP GlobalLuaModules extension.
rybmat
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for global Lua modules in UCP Scribunto, as done before for app in
Wikia/app#4550. Unfortunately Scribunto doesn't offer an
extension point here, so the relevant functionality has to be inlined.
The actual business logic of fetching the content of global modules is handled
by the UCP GlobalLuaModules extension.