PLATFORM-4908 Add ParserAllowExternalImage hook into mediawiki upstream repository
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…maybeMakeExternalImage method" This reverts commit e7282d7.
mmeller-wikia
commented
Feb 16, 2021
| @@ -97,7 +97,9 @@ class Parser { | |||
| # RegExp to make image URLs (embeds IPv6 part of EXT_LINK_ADDR) | |||
| // phpcs:ignore Generic.Files.LineLength | |||
| const EXT_IMAGE_REGEX = '/^(http:\/\/|https:\/\/)((?:\\[(?i:[0-9a-f:.]+)\\])?[^][<>"\\x00-\\x20\\x7F\p{Zs}\x{FFFD}]+) | |||
| \\/([A-Za-z0-9_.,~%\\-+&;#*?!=()@\\x80-\\xFF]+)\\.((?i)gif|png|jpg|jpeg)$/Sxu'; | |||
| \\/((([A-Za-z0-9_.,~%\\-+&;#*?!=()@\\x80-\\xFF]+)\\.((?i)gif|png|jpg|jpeg|webp|ico|svg))| | |||
| ([0-9a-fA-F]{8}\\-[0-9a-fA-F]{4}\\-[0-9a-fA-F]{4}\\-[0-9a-fA-F]{4}\\-[0-9a-fA-F]{12})(\\/|\\?|$)) | |||
There was a problem hiding this comment.
I don't think they will agree to add this line to upstream (allow to hotlink static assets like https://static.fandom-dev.pl/13baa06b-d6eb-48fb-a75a-25afa0d37929/thumbnail/width/348/height/348 )
mmeller-wikia
requested review from
t-tomalak,
maaartyyynaa and
mszabo-wikia
|
Looks like upstream review suggests it's OK to patch the regex in core to accept query parameters...(https://gerrit.wikimedia.org/r/c/mediawiki/core/+/663183) |
Yeah, I've created a patch and we are waiting for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wikia-inc.atlassian.net/browse/PLATFORM-4908