Skip to content

Commit

Permalink
Update TermIndexEntry usage, per changes in Wikibase
Browse files Browse the repository at this point in the history
  • Loading branch information
filbertkm committed Dec 1, 2016
1 parent 793390f commit f320324
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/PropertySuggester/ResultBuilder.php
Expand Up @@ -102,7 +102,7 @@ private function buildEntry( EntityId $id, array $clusteredTerms, Suggestion $su
}

foreach ( $matchingTerms as $term ) {
switch ( $term->getType() ) {
switch ( $term->getTermType() ) {
case TermIndexEntry::TYPE_LABEL:
$entry['label'] = $term->getText();
break;
Expand Down
5 changes: 3 additions & 2 deletions src/PropertySuggester/SuggestionGenerator.php
Expand Up @@ -2,16 +2,17 @@

namespace PropertySuggester;

use InvalidArgumentException;
use PropertySuggester\Suggesters\SuggesterEngine;
use PropertySuggester\Suggesters\Suggestion;
use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\Entity\Property;
use Wikibase\DataModel\Entity\PropertyId;
use Wikibase\DataModel\Services\Lookup\EntityLookup;
use Wikibase\Lib\Store\TermIndexSearchCriteria;
use Wikibase\TermIndex;
use Wikibase\TermIndexEntry;
use InvalidArgumentException;

/**
* API module helper to generate property suggestions.
Expand Down Expand Up @@ -122,7 +123,7 @@ public function filterSuggestions( array $suggestions, $search, $language, $resu
private function getMatchingIDs( $search, $language ) {
$termIndexEntries = $this->termIndex->getTopMatchingTerms(
array(
new TermIndexEntry( array(
new TermIndexSearchCriteria( array(
'termLanguage' => $language,
'termText' => $search
) )
Expand Down
12 changes: 7 additions & 5 deletions tests/phpunit/PropertySuggester/SuggestionGeneratorTest.php
Expand Up @@ -2,6 +2,7 @@

namespace PropertySuggester;

use InvalidArgumentException;
use MediaWikiTestCase;
use PHPUnit_Framework_MockObject_MockObject;
use PropertySuggester\Suggesters\SuggesterEngine;
Expand All @@ -12,12 +13,11 @@
use Wikibase\DataModel\Snak\PropertySomeValueSnak;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\TermIndex;
use InvalidArgumentException;
use Wikibase\TermIndexEntry;

/**
* @covers PropertySuggester\SuggestionGenerator
*
*
* @group PropertySuggester
* @group API
* @group medium
Expand Down Expand Up @@ -92,10 +92,12 @@ public function testFilterSuggestions() {
*/
private function getTermIndexEntryArrayWithIds( $ids ) {
$termIndexEntries = array();
foreach ( $ids as $id ) {
foreach ( $ids as $i => $id ) {
$termIndexEntries[] = new TermIndexEntry( array(
'entityId' => $id->getNumericId(),
'entityType' => $id->getEntityType(),
'entityId' => $id,
'termLanguage' => 'en',
'termText' => "kitten$i",
'termType' => TermIndexEntry::TYPE_LABEL
) );
}
return $termIndexEntries;
Expand Down

0 comments on commit f320324

Please sign in to comment.