Introduced visitors into datamodel and JSON converter #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New interfaces ValueVisitor and SnakVisitor can be used to avoid casting objects of these types * Renamed ConverterImpl to JsonConverter; restricted public interface to methods for handling EntityDocuments; removed Converter interface as it is not needed * Split JsonConverter into several classes by extracting the respective visitors * Extracted constants from JsonConverter * Renamed "jsonconverter" package to "json" * Updated tests accordingly
This interface is not specific to dumpfiles. For example, it might be useful for implementing a class that writes serialized JSON to some stream.
Seems that this does not get updated by the Maven plugin.
|
I review your code. Your code looking good, but I realized a bug form me side. There is no entry for "qualifiers-order" after the SnakGroup for the qualifiers. Should I make this changes on this branch? |
|
You can also merge this first and make the changes later. It is not really related to the introduction of visitors here. Once this change is merged, I can also try to make #57 mergeable. |
Conflicts: wdtk-datamodel/src/main/java/org/wikidata/wdtk/datamodel/implementation/SomeValueSnakImpl.java
guenthermi
added a commit
that referenced
this pull request
Apr 5, 2014
Introduced visitors into datamodel and JSON converter
fer-rum
pushed a commit
that referenced
this pull request
Apr 16, 2014
Sitelink support (merge only after #55)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
casting objects of these types
methods for handling EntityDocuments; removed Converter interface as it
is not needed
visitors
A lot of code has been moved and renamed in this commit. Although much of the moved code is unchanged, the diff is probably not of much use. Best approach for review might be to just ignore the diff and review the changed files as they are now (the changes in datamodel.implementation are trivial; the main differences are in the json package).