Sitelink support (merge only after #55) #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extend dump file management to support gzipped dump files that do not contain page revisions * Simplify some methods in the file/Web utils for better support of various compressions * Simplify and generalize some methods in the dump file management; fewer method names refer to specific dump files now * Support new dump type "SITES" for sites table dump * Add Sites interface and implementation to datamodel to hold and use sites data * Add new dump file processor for parsing SITES dumps to get Sites object * Add example program that shows how instrument all this to make use of sites data * Renamed MwDumpFileProcessorImpl to MwRevisionDumpFileProcessor, since we have several such classes for several types of dumps now * Updated processing code and tests to work with the changes
|
The test error is "unrealistic CPU time" in the util timer package. Maybe we need to change these tests to be even more forgiving. Otherwise we might get spurious test failures like this in the future as well. |
|
I agree. We maybe should avoid this kind of tests. |
This should largely avoid random test failures even under very strange conditions. If not, we can always increase the new tolerance constant even further.
|
This is now ready for review/merge. |
|
Looks fine to me - merging. |
fer-rum
pushed a commit
that referenced
this pull request
Apr 16, 2014
Sitelink support (merge only after #55)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several extension to add sitelinks support (issue #37). This is based on the changes done in #55, which should be merged first.
contain page revisions
various compressions
fewer method names refer to specific dump files now
sites data
object
sites data
we have several such classes for several types of dumps now