Fix overwriting stored email with blank string when user has no WP email #1200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, if a user did not have a Wikipedia account email, but did enter an email manually into the library, every time they logged in their email would be overwritten with a blank string. After this change, Wikipedia email data is only stored if it contains content.
Phabricator Ticket
https://phabricator.wikimedia.org/T328904
How Has This Been Tested?
Tested locally with a few different accounts having and not having email addresses linked. Added a test, which fails with the old code and passes with the new.
Types of changes
What types of changes does your code introduce? Add an
x
in all the boxes that apply: