Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overwriting stored email with blank string when user has no WP email #1200

Merged
merged 3 commits into from Sep 22, 2023

Conversation

Samwalton9
Copy link
Member

@Samwalton9 Samwalton9 commented Sep 9, 2023

Description

Previously, if a user did not have a Wikipedia account email, but did enter an email manually into the library, every time they logged in their email would be overwritten with a blank string. After this change, Wikipedia email data is only stored if it contains content.

Phabricator Ticket

https://phabricator.wikimedia.org/T328904

How Has This Been Tested?

Tested locally with a few different accounts having and not having email addresses linked. Added a test, which fails with the old code and passes with the new.

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor change (fix a typo, add a translation tag, add section to README, etc.)

@Samwalton9 Samwalton9 temporarily deployed to cicd September 9, 2023 18:19 — with GitHub Actions Inactive
Copy link
Member

@jsnshrmn jsnshrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code makes sense, and local testing verifies that it works. Thanks!

@jsnshrmn jsnshrmn merged commit 297daba into WikipediaLibrary:master Sep 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants