Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add django-dkim #1231

Merged
merged 5 commits into from Dec 6, 2023
Merged

add django-dkim #1231

merged 5 commits into from Dec 6, 2023

Conversation

jsnshrmn
Copy link
Member

@jsnshrmn jsnshrmn commented Dec 5, 2023

Description

sign django emails directly in our app; This should be ready to deploy since I've added appropriate dns records and docker secrets for prod.

Rationale

Our unsigned emails are getting dropped

Phabricator Ticket

https://phabricator.wikimedia.org/T347512

How Has This Been Tested?

I manually updated stating to set me as the contact address and to use this backend instead of the console so that I could easily trigger an email. It now passes validation checks.

Screenshots of your changes (if appropriate):

image

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor change (fix a typo, add a translation tag, add section to README, etc.)

@jsnshrmn jsnshrmn marked this pull request as ready for review December 6, 2023 05:12
@suecarmol suecarmol merged commit 61fae64 into master Dec 6, 2023
6 checks passed
@jsnshrmn jsnshrmn deleted the Jsn.sherman/T347512 branch December 7, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants