Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terms of Use title should move to the right-hand side for RTL languages #1308

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

katydidnot
Copy link
Contributor

@katydidnot katydidnot commented Jun 20, 2024

Description

Describe your changes in detail following the commit message guidelines

When accepting the terms of use in a right to left language, the title is in the incorrect location.
Bug: T366046

Rationale

To fix terms title text placement for right to left languages.

Phabricator Ticket

T366046

How Has This Been Tested?

Can be tested manually by switching your language to a right to left language when accepting the terms.

Screenshots of your changes (if appropriate):

Screenshot_2024-05-28_at_09 55 27

It is now respecting the right to left css transformation that situates it in the correct location.
Screenshot 2024-06-20 at 11 58 22 AM

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor change (fix a typo, add a translation tag, add section to README, etc.)

@katydidnot katydidnot marked this pull request as ready for review June 20, 2024 17:46
Copy link
Contributor

@suecarmol suecarmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working for me in my local environment. Thank you for the bug fix!

@suecarmol suecarmol merged commit 5342ac5 into master Jun 21, 2024
5 checks passed
@suecarmol suecarmol deleted the kgraessle/T366046 branch June 21, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants