Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corriere Della Sera Archives often goes blank when attempting to view… #1309

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

katydidnot
Copy link
Contributor

@katydidnot katydidnot commented Jun 21, 2024

Description

Describe your changes in detail following the commit message guidelines

Corriere Della Sera Archives often goes blank when attempting to view a newspaper

Bug: T345104

Rationale

Steps to reproduce:

  • Access Corriere Della Sera Archives
  • Search for a term
  • Click the Eye next to a result to view the newspaper
  • Sometimes the paper will load no problem, sometimes it will partially load, and then the screen will go blank grey.

Phabricator Ticket

https://phabricator.wikimedia.org/T345104

How Has This Been Tested?

If you go to The Wikipedia Library in production and modify the html directly in the browser for the "Access Collection" button to remove the rel="noreferrer" then the website loads as expected with the content loading as expected.

Screenshots of your changes (if appropriate):

Screenshot 2024-06-21 at 8 24 13 AM

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor change (fix a typo, add a translation tag, add section to README, etc.)

@katydidnot katydidnot marked this pull request as ready for review June 21, 2024 13:34
@katydidnot katydidnot marked this pull request as draft June 21, 2024 13:38
@katydidnot katydidnot marked this pull request as ready for review June 21, 2024 14:03
@suecarmol
Copy link
Contributor

Have you pushed these changes to staging so we can test them there?

@katydidnot
Copy link
Contributor Author

Have you pushed these changes to staging so we can test them there?

I just pushed it to the staging branch and the job succeeded.
https://github.com/WikipediaLibrary/TWLight/actions/runs/9618116730

Do I need to do the rest of the steps here?

Or is that only if the CI job fails?

@katydidnot katydidnot marked this pull request as draft June 21, 2024 18:41
@suecarmol
Copy link
Contributor

No, the changes are already reflected!

@suecarmol suecarmol marked this pull request as ready for review June 21, 2024 18:46
Copy link
Contributor

@suecarmol suecarmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this on staging and the newspapers no longer go blank when loading. Thanks for the bug fix!

@suecarmol suecarmol merged commit 94049b3 into master Jun 21, 2024
6 checks passed
@suecarmol suecarmol deleted the kgraessle/T345104 branch June 21, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants