Fixed encoding server error + wrote CSV download tests

TWLight/graphs/tests.py

@@ -1,4 +1,6 @@
+# -*- coding: utf-8 -*-
 import csv
+from datetime import date
 # django-request analytics package, NOT requests URL library!
 from request.models import Request
 
@@ -7,6 +9,11 @@
 from django.test import TestCase
 from django.test.client import RequestFactory
 
+from TWLight.applications.factories import ApplicationFactory
+from TWLight.applications.models import Application
+from TWLight.resources.factories import PartnerFactory
+from TWLight.users.factories import UserFactory
+
 from . import views
 
 class GraphsTestCase(TestCase):
@@ -20,10 +27,21 @@ def setUpClass(cls):
         Request(path='/admin/', ip='127.0.0.1').save()
         Request(path='/admin/login/', ip='127.0.0.1').save()
 
-        user = User.objects.create_user(username='foo', password='bar')
-        user.is_staff = True
-        user.save()
-        cls.staff_user = user
+        staff_user = User.objects.create_user(username='foo', password='bar')
+        staff_user.is_staff = True
+        staff_user.save()
+        cls.staff_user = staff_user
+
+        user = UserFactory()
+        cls.user = user
+
+        cls.partner = PartnerFactory()
+
+        cls.app = ApplicationFactory(partner=cls.partner)
+        cls.app.status = Application.APPROVED
+        cls.app.save()
+
+        cls.dashboard_url = reverse('dashboard')
 
 
     def _verify_equal(self, resp, expected_data):
@@ -40,6 +58,112 @@ def _verify_equal(self, resp, expected_data):
         self.assertEqual(reader_list.line_num, len(expected_data) + 1)
 
 
+    def test_dashboard_view(self):
+        """
+        Test that the dashboard view works at all for a normal user
+        who isn't currently logged in.
+        """
+        request = self.factory.get(self.dashboard_url)
+        request.user = self.user
+
+        response = views.DashboardView.as_view()(request)
+        self.assertEqual(response.status_code, 200)
+
+
+    def test_app_time_histogram_csv(self):
+        """
+        Test that the CSVAppTimeHistogram csv download works
+        """
+
+        request = self.factory.get(reverse('csv:app_time_histogram'))
+        request.user = self.user
+
+        response = views.CSVAppTimeHistogram.as_view()(request)
+
+        expected_data = [['0', '1']]
+
+        self._verify_equal(response, expected_data)
+
+
+    def test_num_approved_applications_csv(self):
+        """
+        Test that the CSVNumApprovedApplications csv download works
+        """
+
+        request = self.factory.get(reverse('csv:num_applications'))
+        request.user = self.user
+
+        response = views.CSVNumApprovedApplications.as_view()(request)
+
+        # The application was created today, so the expectation is that the
+        # resulting data will be an application for today.
+        expected_data = [[str(date.today()), '1']]
+
+        self._verify_equal(response, expected_data)
+
+
+    def test_app_distribution_csv(self):
+        """
+        Test that the CSVAppDistribution csv download works
+        """
+        # Create some applications with different statuses
+        for app_status in [Application.PENDING, Application.APPROVED, Application.QUESTION]:
+            app = ApplicationFactory()
+            app.status = app_status
+            app.save()
+
+        request = self.factory.get(reverse('csv:app_distribution'))
+        request.user = self.user
+
+        response = views.CSVAppDistribution.as_view()(request)
+
+        expected_data = [['Pending', '1'],
+                         ['Approved', '2'],
+                         ['Under discussion', '1'],
+                         ['Sent to partner', '0'],
+                         ['Not approved', '0'],
+                         ['Invalid', '0']]
+
+        self._verify_equal(response, expected_data)
+
+
+    def test_user_language_csv(self):
+        """
+        Test that the CSVUserLanguage csv download works
+        """
+        for language in ['en', 'fr', 'fr', 'de']:
+            user = UserFactory()
+            user.userprofile.lang = language
+            user.userprofile.save()
+
+        request = self.factory.get(reverse('csv:user_language'))
+        request.user = self.user
+
+        response = views.CSVUserLanguage.as_view()(request)
+
+        expected_data = [['en', '1'],['fr', '2'],['de', '1']]
+
+        self._verify_equal(response, expected_data)
+
+
+    def test_app_medians_csv(self):
+        """
+        Test that the CSVAppMedians csv download works
+        """
+
+        request = self.factory.get(reverse('csv:app_medians'))
+        request.user = self.user
+
+        response = views.CSVAppMedians.as_view()(request)
+
+        # The application was created today, so the expectation is that the
+        # resulting data will be an application for this month with 0 days
+        # to decision (we approved it immediately).
+        expected_data = [[str(date.today().replace(day=1)), '0']]
+
+        self._verify_equal(response, expected_data)
+
+
     def test_csv_page_views(self):
         url = reverse('csv:page_views')
 
@@ -88,3 +212,67 @@ def test_csv_page_views_by_path(self):
         expected_data = [['/fake/url/', '0']]
 
         self._verify_equal(resp, expected_data)
+
+
+    def test_app_count_by_partner_csv(self):
+        """
+        Test that the CSVAppCountByPartner csv download works
+        """
+        request = self.factory.get(reverse('csv:app_count_by_partner',
+            kwargs={'pk': self.partner.pk}))
+        request.user = self.user
+
+        response = views.CSVAppCountByPartner.as_view()(request,
+            pk=self.partner.pk)
+
+        expected_data = [[str(date.today().replace(day=1)), '1']]
+
+        self._verify_equal(response, expected_data)
+
+
+    def test_user_count_by_partner_csv(self):
+        """
+        Test that the CSVUserCountByPartner csv download works
+        """
+        request = self.factory.get(reverse('csv:user_count_by_partner',
+            kwargs={'pk': self.partner.pk}))
+        request.user = self.user
+
+        response = views.CSVUserCountByPartner.as_view()(request,
+            pk=self.partner.pk)
+
+        expected_data = [[str(date.today().replace(day=1)), '1']]
+
+        self._verify_equal(response, expected_data)
+
+
+    def test_app_distribution_by_partner_csv(self):
+        """
+        Test that the CSVAppDistribution csv download works
+        """
+        for app_status in [Application.PENDING, Application.APPROVED, Application.QUESTION]:
+            app = ApplicationFactory(partner=self.partner)
+            app.status = app_status
+            app.save()
+
+        # Let's create an application for a different partner too, which
+        # shouldn't be counted.
+        app = ApplicationFactory()
+        app.status = Application.APPROVED
+        app.save()
+
+        request = self.factory.get(reverse('csv:app_distribution_by_partner',
+            kwargs={'pk': self.partner.pk}))
+        request.user = self.user
+
+        response = views.CSVAppDistribution.as_view()(request,
+            pk=self.partner.pk)
+
+        expected_data = [['Pending', '1'],
+                         ['Approved', '2'],
+                         ['Under discussion', '1'],
+                         ['Sent to partner', '0'],
+                         ['Not approved', '0'],
+                         ['Invalid', '0']]
+
+        self._verify_equal(response, expected_data)

TWLight/graphs/views.py

@@ -290,8 +290,8 @@ def _write_data(self, response):
         writer = csv.writer(response)
 
         writer.writerow([_('Date'),
-            # Translators: This is the heading of a data file which lists the number of applications to a partner. Don't translate {partner}.
-            _('Number of applications to {partner}').format(partner=partner)])
+            # Translators: This is the heading of a data file which lists the number of applications to a partner.
+            _('Number of applications')])
 
         for row in data:
             writer.writerow(row)
@@ -314,8 +314,8 @@ def _write_data(self, response):
         writer = csv.writer(response)
 
         writer.writerow([_('Date'),
-            # Translators: This is the heading of a data file which lists the number of unique (not counting repeat applications) users who have applied to a partner. Don't translate {partner}.
-            _('Number of unique users who have applied to {partner}').format(partner=partner)])
+            # Translators: This is the heading of a data file which lists the number of unique (not counting repeat applications) users who have applied to a partner.
+            _('Number of unique users who applied')])
 
         for row in data:
             writer.writerow(row)