Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T205531 #430

Merged
merged 3 commits into from
Jun 12, 2020
Merged

T205531 #430

merged 3 commits into from
Jun 12, 2020

Conversation

Rohan-cod
Copy link
Contributor

No description provided.

@Samwalton9
Copy link
Member

Thanks @Rohan-cod!

We have a requirement on code style - could you run docker-compose exec twlight /venv/bin/black -t py37 /app/TWLight and commit the result? This will just reformat the code slightly. My fault, my example code wasn't well formatted! :)

@Rohan-cod
Copy link
Contributor Author

@Samwalton9, I am getting this error.
Screenshot 2020-03-10 at 4 23 55 PM

@Rohan-cod
Copy link
Contributor Author

Hi @Samwalton9, I corrected the last error. It was due to installation from brew. Now I am getting this error. Can you help me out with this one?
Screenshot 2020-03-11 at 9 41 16 PM

@lalit97
Copy link
Contributor

lalit97 commented Mar 13, 2020

Hello @Rohan-cod I have faced the similar issue while setting this up. To resolve this just go the project root and install this manually i.e. npm install --save cssjanus

@Rohan-cod
Copy link
Contributor Author

@lalit97, I am getting this now
Screenshot 2020-03-13 at 3 27 25 PM

@lalit97
Copy link
Contributor

lalit97 commented Mar 13, 2020

run npm audit fix and then share a screenshot of your package-lock.json file.

@Rohan-cod
Copy link
Contributor Author

Screenshot 2020-03-13 at 4 28 49 PM

@Rohan-cod
Copy link
Contributor Author

debug.log
Screenshot 2020-03-13 at 4 29 52 PM

@lalit97
Copy link
Contributor

lalit97 commented Mar 13, 2020

run the following commands from the project root
(1) npm init
(2) npm install cssjanus --save

@Rohan-cod
Copy link
Contributor Author

package-lock.json
Screenshot 2020-03-13 at 5 32 32 PM

@lalit97
Copy link
Contributor

lalit97 commented Mar 13, 2020

This looks right to me, does the error still exists?

@Rohan-cod
Copy link
Contributor Author

Yeah, it's still there.

@lalit97
Copy link
Contributor

lalit97 commented Mar 13, 2020

Have you tried these? #430 (comment)

just post screenshot of error and git status.

@Rohan-cod
Copy link
Contributor Author

Screenshot 2020-03-13 at 6 13 30 PM

@Rohan-cod
Copy link
Contributor Author

Rohan-cod commented Mar 13, 2020

I have tried those commands

@lalit97
Copy link
Contributor

lalit97 commented Mar 13, 2020

everything looks perfect, just try restarting the docker once.

@Rohan-cod
Copy link
Contributor Author

Restarted docker, but still not resolved.

@lalit97
Copy link
Contributor

lalit97 commented Mar 13, 2020

Can you post the current error's screenshot?

doing the same things worked for me, don't know what is going wrong in yours.

Screen Shot 2020-03-13 at 8 29 09 PM

Screen Shot 2020-03-13 at 8 28 44 PM

@Rohan-cod
Copy link
Contributor Author

Screenshot 2020-03-13 at 9 13 47 PM

@lalit97
Copy link
Contributor

lalit97 commented Mar 13, 2020

rm -rf node_modules
npm install cssjanus --save

just try these 2 commands from root

@Rohan-cod
Copy link
Contributor Author

@lalit97, still getting the same error.

@lalit97
Copy link
Contributor

lalit97 commented Mar 14, 2020

does your project bin/ directory contains file named twlight_cssjanus.js

@Rohan-cod
Copy link
Contributor Author

yes
Screenshot 2020-03-14 at 1 23 54 PM

@lalit97
Copy link
Contributor

lalit97 commented Mar 14, 2020

The error is occurring when app/bin/twlight_static.sh is running
Inside this app/bin/twlight_cssjanus.js is being called

# Generate right to left css
cd ${TWLIGHT_HOME} && node ${TWLIGHT_HOME}/bin/twlight_cssjanus.js || exit 1
# Load virtual environment

Which is already there in your bin/directory.
Inside app/bin/twlight_cssjanus.js we are importing cssjanus from our node_modules

// Load modules
var fs = require('fs');
var cssjanus = require('cssjanus');

So I think then there must be some problem related to node/modules in your case.
Posting my document tree of node_modules just check if yours have the same structure

Screen Shot 2020-03-14 at 2 15 48 PM

@Rohan-cod
Copy link
Contributor Author

Rohan-cod commented Mar 14, 2020

My tree structure is also same, just checked.
Screenshot 2020-03-14 at 5 28 56 PM

@lalit97
Copy link
Contributor

lalit97 commented Mar 17, 2020

Okay, I will look for some alternate solutions and get back to you soon

@lalit97
Copy link
Contributor

lalit97 commented Jun 7, 2020

Hi Rohan, are you still looking for it?
Since the docker file is updated you can try the installation process once more maybe it will work this time.

@Rohan-cod
Copy link
Contributor Author

Hi Rohan, are you still looking for it?
Since the docker file is updated you can try the installation process once more maybe it will work this time.

Thanks @lalit97, I will surely try it.

@jsnshrmn
Copy link
Member

I rebased this so I can check it against our current code base and review.

@jsnshrmn
Copy link
Member

I ran black for you so that we can look at the content of the code rather than the style.

…data.py

Co-authored-by: Jason Sherman <jsnshrmn@users.noreply.github.com>
@Rohan-cod
Copy link
Contributor Author

Thanks for the help @jsnshrmn. :)

@jsnshrmn
Copy link
Member

I built this locally and manually ran the command. I verified that example application renewals now happen between the original application date and today.
Thanks for your contribution!🎉

@jsnshrmn jsnshrmn merged commit fcead5f into WikipediaLibrary:master Jun 12, 2020
@Rohan-cod
Copy link
Contributor Author

You’re very welcome, @jsnshrmn It was my pleasure! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants