Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GlitchTip to staging and production environments #599

Merged
merged 6 commits into from Feb 3, 2021
Merged

Add GlitchTip to staging and production environments #599

merged 6 commits into from Feb 3, 2021

Conversation

suecarmol
Copy link
Contributor

Description

Added GlitchTip integration to the staging and production environments.

Rationale

We are expecting more users in the application once the Echo notification is rolled out. Setting up an exception logging service will help us monitor and debug any errors we encounter more efficiently.

Phabricator Ticket

T262931

How Has This Been Tested?

Deploying the changes to staging and navigating to a view that has an error on it.

Screenshots of your changes (if appropriate):

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@suecarmol suecarmol changed the title WIP - Add GlitchTip to staging and production environments Add GlitchTip to staging and production environments Feb 2, 2021
Copy link
Member

@jsnshrmn jsnshrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to keep DEFAULT_FROM_EMAIL for non-error email sending and set it to the current value of SERVER_EMAIL which can still be dropped. Otherwise this is ready to merge!

@suecarmol
Copy link
Contributor Author

Done! Thanks for pointing that out :)

@jsnshrmn jsnshrmn merged commit cbf46f6 into WikipediaLibrary:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants