Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tags field and django-taggit library #701

Merged
merged 6 commits into from May 11, 2021
Merged

Remove tags field and django-taggit library #701

merged 6 commits into from May 11, 2021

Conversation

suecarmol
Copy link
Contributor

Description

Remove the tags field and everything that has to do with it.

Rationale

After #688 was merged, the tags field is no longer needed, therefore, the django-taggit dependency isn't needed either.

Phabricator Ticket

T282034

How Has This Been Tested?

Screenshots of your changes (if appropriate):

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor change (fix a typo, add a translation tag, add section to README, etc.)

@suecarmol suecarmol changed the title WIP Remove tagsfield and django-taggit library WIP Remove tags field and django-taggit library May 10, 2021
@suecarmol suecarmol changed the title WIP Remove tags field and django-taggit library Remove tags field and django-taggit library May 10, 2021
@suecarmol suecarmol requested a review from jsnshrmn May 10, 2021 23:37
Copy link
Member

@jsnshrmn jsnshrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great overall!
It initially seemed strange to me that you edited the initial migration, but I realized that you had to since the dependency is being removed.
Thanks for your work!

@jsnshrmn jsnshrmn merged commit 5ef198f into WikipediaLibrary:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants