Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement UI favorites #840

Merged
merged 6 commits into from Oct 7, 2021
Merged

Implement UI favorites #840

merged 6 commits into from Oct 7, 2021

Conversation

suecarmol
Copy link
Contributor

@suecarmol suecarmol commented Oct 6, 2021

Description

Implement the UI for the collection favoriting system:

  • Add a Favorites tab
  • Add a star to add collections to favorites
  • Add view that works asynchronously to favorite a collection

Rationale

Favoriting collections is a highly requested feature for the Library.

Phabricator Ticket

T285671

How Has This Been Tested?

Tested manually

Screenshots of your changes (if appropriate):

Favoriting

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor change (fix a typo, add a translation tag, add section to README, etc.)

@suecarmol suecarmol changed the title WIP - Implement UI favorites Implement UI favorites Oct 6, 2021
Copy link
Member

@jsnshrmn jsnshrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I manually tested this emulating a few different mobile devices, and found that it worked as expected. In the interest of expediency, I'm going to go ahead and merge this in, even though it could use unit tests.

@jsnshrmn jsnshrmn merged commit d9f55d6 into WikipediaLibrary:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants