New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a URL which initiates a library search #871
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnshrmn
force-pushed
the
jason-T294919
branch
2 times, most recently
from
November 4, 2021 19:18
f9cd8eb
to
1731883
Compare
jsnshrmn
changed the title
WIP Create a URL which initiates a library search
Create a URL which initiates a library search
Nov 4, 2021
jsnshrmn
force-pushed
the
jason-T294919
branch
from
November 4, 2021 19:21
1731883
to
190751c
Compare
jsnshrmn
force-pushed
the
jason-T294919
branch
from
November 8, 2021 16:09
82b884a
to
1935642
Compare
suecarmol
requested changes
Nov 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small change before I can merge this
- name things more logically - add proper language code handling - add javascript form submit onLoad
jsnshrmn
force-pushed
the
jason-T294919
branch
from
November 10, 2021 14:30
1935642
to
17a7462
Compare
suecarmol
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds:
/search/?q=<search terms>
that sends users from stable urls on-wiki to searches in EDS.Updates:
from_homepage
query parameter once our auth check is done using itRationale
For use in the Find Sources template
Phabricator Ticket
https://phabricator.wikimedia.org/T294919
How Has This Been Tested?
I added unit tests for the new view mixin, since that is reusable and has security implications.
I manually tested:
pt
, with JavaScript enabled and disabled.Screenshots of your changes (if appropriate):
nojs screenshot; the javascript version automatically sends the user to EDS.
Types of changes
What types of changes does your code introduce? Add an
x
in all the boxes that apply: