New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wp_block_hash field #923
Add wp_block_hash field #923
Conversation
56830e5
to
5c450dd
Compare
6f89413
to
2827c71
Compare
2827c71
to
8cae0a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of your work on this! It is looking really good. There is only one thing that sticks out at me, and it's not actually a problem. It's the fact that the email send is setup directly in the user helper. We're using signals for sending emails in other places, but I don't think there is any advantage to registering a signal here; it has me wondering why I implemented so many of the other signals. Great work!
Description
Added the
wp_block_hash
field and validated if the block has has changed everytime the user logs inRationale
We want a system for reviewing users with ignored block status in the case that their block status changes, so that we can evaluate if they should still be added to the allow list.
Phabricator Ticket
T295608
How Has This Been Tested?
Screenshots of your changes (if appropriate):
Types of changes
What types of changes does your code introduce? Add an
x
in all the boxes that apply: