Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new guard clause in editor_compare_hashes helper function #940

Merged
merged 2 commits into from Jan 27, 2022

Conversation

suecarmol
Copy link
Contributor

Description

Added a new guard clause in the editor_compare_hashes helper function to check if a user has a block override before sending the email.

Rationale

Emails are being sent when any editor's block status is changed.

Phabricator Ticket

T295608

How Has This Been Tested?

Added new test

Screenshots of your changes (if appropriate):

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor change (fix a typo, add a translation tag, add section to README, etc.)

@suecarmol suecarmol changed the title WIP - Add new guard clause in editor_compare_hashes helper function Add new guard clause in editor_compare_hashes helper function Jan 27, 2022
Copy link
Member

@jsnshrmn jsnshrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jsnshrmn jsnshrmn merged commit c32be79 into WikipediaLibrary:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants