Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable linking a suggestion to a phabricator ticket #980

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Enable linking a suggestion to a phabricator ticket #980

merged 1 commit into from
Mar 28, 2022

Conversation

lalit97
Copy link
Contributor

@lalit97 lalit97 commented Mar 19, 2022

Description

When users file suggestions for new collections, they want to be able to track the progress of that request as the maintainers go through their pipeline for trying to get a partnership with the suggested partner

Rationale

We need a way to link the suggestions to a Phabricator ticket so that users who visit the suggestion page can click through to see what the progress on that request

Phabricator Ticket

https://phabricator.wikimedia.org/T299883

How Has This Been Tested?

By going to the suggest collection page and clicking on the Phabricator ticket link.

Screenshots of your changes (if appropriate):

sample

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor change (fix a typo, add a translation tag, add section to README, etc.)

We need a way to link the suggestions to a Phabricator ticket, so that users who visit the suggestion page can click through to see what the progress on that request

Bug: T299883
Copy link
Contributor

@suecarmol suecarmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this task!

@suecarmol suecarmol merged commit 34711bb into WikipediaLibrary:master Mar 28, 2022
@lalit97
Copy link
Contributor Author

lalit97 commented Mar 29, 2022

Thank you for the review, my pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants