Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkey combo for Windows doesn't work in sprint 42 experimental build 0.42.0-13957 #9

Closed
jbmonroe opened this issue Sep 3, 2014 · 6 comments

Comments

@jbmonroe
Copy link

jbmonroe commented Sep 3, 2014

Assuming all I have to do is drop the cursor into the name of the function and hit Ctrl-Alt-D, I'm not getting any response, even after restarting Brackets. Is this just a problem with the version of Brackets?

@Wikunia
Copy link
Owner

Wikunia commented Sep 3, 2014

Do you have any errors insde your DevTools? Debug->Show Dev Tools
Or can you send me your function snippet?
You need a function with { and }

@jbmonroe
Copy link
Author

jbmonroe commented Sep 3, 2014

I didn't see any issues in the Dev Tools view with FuncDocr.

Here's one of the functions:

    function describe(n)
    {
        if (n === 0) {
            return "(OK)";
        }
        return "(error code " + n.toString() + ")";
    }

On Wed, Sep 3, 2014 at 10:24 AM, Ole Kröger notifications@github.com
wrote:

Do you have any errors insde your DevTools? Debug->Show Dev Tools
Or can you send me your function snippet?
You need a function with { and }


Reply to this email directly or view it on GitHub
#9 (comment)
.

@Wikunia
Copy link
Owner

Wikunia commented Sep 3, 2014

Ah okay, sorry I never used this format :D
Always have the { in the line and not in the next.
I am working on a FuncDocr feature at the moment and implement your declaration afterward if it's okay.

@Wikunia
Copy link
Owner

Wikunia commented Sep 3, 2014

Or for the moment you can change the var FUNCTION_REGEXP line into
var FUNCTION_REGEXP = /function(?:\s+[A-Za-z\$\_][A-Za-z\$\_0-9]*)?\s*\(([^\)]*)\)/;

@jbmonroe
Copy link
Author

jbmonroe commented Sep 3, 2014

Yes, that's good--I was just debugging and noticed it wasn't happy with
FUNCTION_REGEXP. (Been doing the brackets on function declarations
differently for years--it became the standard in our shop for both C++ and
Javascript. I think it's one of those "One True Indent" patterns. shrug
Everyone has an idea as to what's best. :) )

I applied the fix and it works as expected...love the extension because it
saves me so much time. Now if I can just get the rest of the team to use
Brackets. ;)

On Wed, Sep 3, 2014 at 11:43 AM, Ole Kröger notifications@github.com
wrote:

Or for the moment you can change the var FUNCTION_REGEXP line into
var FUNCTION_REGEXP =
/function(?:\s+[A-Za-z$][A-Za-z$0-9])?\s(([^)]*))/;


Reply to this email directly or view it on GitHub
#9 (comment)
.

@Wikunia
Copy link
Owner

Wikunia commented Sep 3, 2014

Btw if you have some ideas => Feel free to ask ;)

Wikunia pushed a commit that referenced this issue Sep 3, 2014
@Wikunia Wikunia closed this as completed Sep 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants