Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple fixes resolving all previously opened issues #11

Closed
wants to merge 5 commits into from
Closed

multiple fixes resolving all previously opened issues #11

wants to merge 5 commits into from

Conversation

avril-gh
Copy link
Contributor

multiple fixes resolving all previously opened issues

  • invalid html output fixes.
  • avatar problems fixes.
  • division by zero error fixes.

…nd staff online modules

Fixes for whos online and staff online modules.

- fixed division by zero bug and various other bugs within these 2
modules.
- added functionality where value of 0 for columns or rows set in
options panel will hide avatars and leave only text output.
- added text output to staff online module in case of disabling avatars.
- changed various language variables for these 2 modules.
- improved tip for modules in options panel
updated readme to fit current state.
Addressing WildcardSearch/Advanced-Sidebox issue #4
- fixed invalid html output in custom box.
- added auto inserting empty block within custom box tbody section if
user not provide any content for custom box to prevent invalid html.
- converted project files to UTF-8 (without BOM) as required for
multilangual support.
- added missing index.html files
updated version file to 1.3.2c
@WildcardSearch
Copy link
Owner

Okay I don't understand what is happening exactly. Why are all those lines getting changed?

Wouldn't it be easier if I converted the repo from my end to UTF-8 without BOM and then you could just send the pull request? In that way we can actually see what is changing instead of pages of diff that really don't mean anything.

In any event cheers for the hard work.

@avril-gh
Copy link
Contributor Author

I watch very carefuly to stay in sync with your repo to keep ability of easy merging into both sides automaticaly when needed, with one click without conflict problems.

My repo at current stage is very precise mirror of your repo with adv.sbx 1.3.2
Only diff are these changes i marked a b c,
At some point i noticed that it show more diff at commit time, than i actually done.
Then i found that Its because part of files was originally encoded in ANSI and other part in UTF-8
and my IDE is set by default to save as UTF-8.
Then github when comparing, not compare contents of file but exact binary differences in encoding 💤

But anyway, files should be converted to UTF-8 because ANSI may encode only 255 characters
and its impossible to use any national characters ect (like language translations ect ect).
I think this Nayar made it ANSI and no one noticed it until now when we try sync. But its good find.

Wouldn't it be easier if I converted the repo from my end to UTF-8 without BOM and then you could just send the pull request? In that way we can actually see what is changing instead of pages of diff that really don't mean anything.

This can be interesting. You may be rite. Lets try.
Convert everything to UTF-8 then commit it to your repo and then i pull onto it my repo
and we should be able to see true changes not file encoding changes.

But make sure its UTF-8 (w/o BOM) cos PHP files shouldnt have it.
Not a bad idea. Looking forward to it.

@WildcardSearch
Copy link
Owner

-This pull request cannot be automatically merged.

What is that?

@avril-gh
Copy link
Contributor Author

Wait i close it and send other

@avril-gh avril-gh closed this Jan 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants