Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming change to tree-sitter-clojure #448

Closed
sogaiu opened this issue Dec 22, 2022 · 1 comment
Closed

Upcoming change to tree-sitter-clojure #448

sogaiu opened this issue Dec 22, 2022 · 1 comment

Comments

@sogaiu
Copy link
Contributor

sogaiu commented Dec 22, 2022

I'm opening this issue to let the maintainers know that we're planning to merge a change to the tree-sitter-clojure master branch that might be of interest to this repository.

The change is here: sogaiu/tree-sitter-clojure#31

A brief overview of the changes follows.

kwd_lit and sym_lit will now contain up to 3 new nodes:

(kwd_lit
  ns: (kwd_ns)
  delimiter: "/"
  name: (kwd_name))

(sym_lit
  ns: (sym_ns)
  delimiter: "/"
  name: (sym_name))

Only the (kwd_name) and (sym_name) are required.

sym_lit nodes can still contain metadata nodes (this is unchanged).


IIUC, difftastic currently uses a commit on the issue-21 branch of tree-sitter-clojure -- at least it seems so according to:

So if that assessment is correct and the dependency doesn't change it seems our intended upcoming change shouldn't have any effect.

However, the change should also address sogaiu/tree-sitter-clojure#21 which Wilfred reported to us earlier, so may be there would be some interest in using the updated code?

Please let us know if you decide to try the new code as well as if you encounter any issues.

Thanks!

P.S. Our current plan is to merge around 2023-01-05 which is in about 2 weeks time.


On a more general note...

Though at this time we don't anticipate many changes going forward, we're planning to post certain change-related announcements to a pinned issue ahead of merging such changes.

Please have a look at the issue and consider subscribing :)

@Wilfred
Copy link
Owner

Wilfred commented Mar 15, 2023

Works nicely, thanks for letting me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants