Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setopt for "set" button if available #332

Merged

Conversation

LemonBreezes
Copy link
Contributor

@LemonBreezes LemonBreezes commented Oct 19, 2023

Hello. This PR allows for customizing the prompt which Helpful prefills when we click the "set" button. By default I've set helpful up to use setopt if available since setting some variables will not work if they are just set with setq.

I made it customizable so that Doom Emacs could set it to setq!.

@Wilfred Wilfred merged commit a32a5b3 into Wilfred:master Oct 28, 2023
4 checks passed
@Wilfred
Copy link
Owner

Wilfred commented Oct 28, 2023

Seems reasonable, thanks.

Why would Doom Emacs want to treat this differently? I don't understand what's different about that situation.

@LemonBreezes
Copy link
Contributor Author

LemonBreezes commented Oct 28, 2023

Seems reasonable, thanks.

Why would Doom Emacs want to treat this differently? I don't understand what's different about that situation.

To be honest, the primary reason is that setq! is guaranteed to be there for earlier Emacs versions (since we define it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants