Upgrade rust-toolchain to nightly-2018-09-09 #852

harryfei · 2018-09-04T05:15:32Z

Closes #752
Closes #759
Closes #725
Unblock #757

rust_src/remacs-macros/lib.rs

shaleh · 2018-09-04T17:04:52Z

rust_src/rustfmt.toml

@@ -26,28 +26,22 @@ max_width = 100
 merge_derives = true
 newline_style = "Unix"
 normalize_comments = false


Are these still supported in some way?

They are default already. The options are deleted.

Good! Thanks.

shaleh · 2018-09-04T17:07:13Z

rust_src/src/lib.rs

 #![feature(const_fn)]
-#![feature(const_size_of)]
 #![allow(non_upper_case_globals)]
 #![allow(non_snake_case)]
 #![allow(private_no_mangle_fns)]
 #![allow(non_camel_case_types, non_snake_case, non_upper_case_globals)]


Maybe move this comment before the allow instead of allowing it to be placed after?

shaleh

When I looked at this last there were issues with the OSX allocation code. I do not see any patches in here for that. What was the final resolution?

harryfei · 2018-09-05T12:03:43Z

@shaleh Yes, you are right. After checking the travis-ci output, I found this PR breaks the build on OSX (allocation code).
However, I don't have an OSX machine. I can't fix the build issue by myself.
Could we merge the PR first and wait for a new patch to fix the OSX build issue (by someone else).

shaleh · 2018-09-05T16:28:00Z

A significant number of us use OSX. I am loathe to merge this without a solution.

I had not worked on it because the Rust team was still deciding on the API for the allocation interface. If that has settled porting this over should not be too hard.

SolarAquarion · 2018-09-06T13:07:59Z

   Compiling remacs-macros v0.1.0 (file:///home/solaraquarion/build/remacs-git/src/remacs-git/rust_src/remacs-macros)
   Compiling remacs v0.1.0 (file:///home/solaraquarion/build/remacs-git/src/remacs-git/rust_src)
error[E0573]: expected type, found module `AtkScrollType`
      --> /home/solaraquarion/build/remacs-git/src/remacs-git/rust_src/target/release/build/remacs-4c2b5b016a5b1bfb/out/bindings.rs:141760:67
       |
141760 |         unsafe extern "C" fn(component: *mut AtkComponent, type_: AtkScrollType) -> gboolean,
       |                                                                   ^^^^^^^^^^^^^ did you mean `GtkScrollType`?

error[E0573]: expected type, found module `AtkScrollType`
      --> /home/solaraquarion/build/remacs-git/src/remacs-git/rust_src/target/release/build/remacs-4c2b5b016a5b1bfb/out/bindings.rs:142069:73
       |
142069 |     pub fn atk_component_scroll_to(component: *mut AtkComponent, type_: AtkScrollType) -> gboolean;
       |                                                                         ^^^^^^^^^^^^^ did you mean `GtkScrollType`?

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0573`.
error: Could not compile `remacs`.

To learn more, run the command again with --verbose.
make[1]: *** [Makefile:609: ../rust_src/target/release/libremacs_lib.a] Error 101
make[1]: Leaving directory '/home/solaraquarion/build/remacs-git/src/remacs-git/src'

harryfei · 2018-09-07T02:00:34Z

@SolarAquarion Which platform did you build on？The code can built on Linux perfectly while has some issues on MacOS.

Besides, do make clean may be helpful in some situation.

SolarAquarion · 2018-09-07T02:08:56Z

I had a git version of atk which caused the issue On Sep 6, 2018 10:00 PM, "Harry Fei" <notifications@github.com> wrote: @SolarAquarion <https://github.com/SolarAquarion> Which platform did you build on？The code can build on Linux perfectly while has some issue on MacOS. Besides, do make clean may be helpful in some situation. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#852 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFD6iECvd2muAfQixoAzW_t3bJ6mpvNnks5uYdNFgaJpZM4WYTub> .

harryfei · 2018-09-07T02:16:41Z

@shaleh I will try my best to fix the OSX build issues in future updates.

harryfei · 2018-09-09T15:34:34Z

@shaleh

Fix the build issue on mac osx
update the toolchain to nightly-2018-09-09

shaleh · 2018-09-09T15:57:36Z

Thanks! Last time I tried the alloc code was not settled enough. That diff is what I was hoping to eventually see.

shaleh

Great work!

OSX is still not building....

cbbrowne · 2018-09-10T16:56:10Z

I tried doing a build of this (Linux - Debian) and had failures:

There were a number of broken references when trying to make temacs:

/home/cbbrowne/GitStuff/remacs/rust_src/src/lists.rs:184: undefined reference to Ffuncall' /usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.u0bumo365vjn2b3.rcgu.o): in function remacs::multibyte::string_overflow':
/home/cbbrowne/GitStuff/remacs/rust_src/src/multibyte.rs:239: undefined reference to make_string' /usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.u0bumo365vjn2b3.rcgu.o): in function remacs::multibyte::write_codepoint':
/home/cbbrowne/GitStuff/remacs/rust_src/src/multibyte.rs:340: undefined reference to make_string' /usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.y54rppfya31h0vi.rcgu.o): in function store_symval_forwarding':
/home/cbbrowne/GitStuff/remacs/rust_src/src/data.rs:480: undefined reference to Fget' /usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/data.rs:486: undefined reference to Fget'
/usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/data.rs:494: undefined reference to Ffuncall' /usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.y54rppfya31h0vi.rcgu.o): in function remacs::data::aset':
/home/cbbrowne/GitStuff/remacs/rust_src/src/data.rs:216: undefined reference to CHECK_IMPURE' /usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/data.rs:222: undefined reference to CHAR_TABLE_SET'
/usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/data.rs:229: undefined reference to CHECK_IMPURE' /usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/data.rs:237: undefined reference to aset_multibyte_string'
/usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/data.rs:245: undefined reference to aset_multibyte_string' /usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.y54rppfya31h0vi.rcgu.o): in function remacs::data::defalias':
/home/cbbrowne/GitStuff/remacs/rust_src/src/data.rs:(.text._ZN6remacs4data8defalias17h404658934f808684E+0x60): undefined reference to globals' /usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/data.rs:273: undefined reference to Fpurecopy'
/usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/data.rs:(.text._ZN6remacs4data8defalias17h404658934f808684E+0x177): undefined reference to globals' /usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/data.rs:284: undefined reference to Fcons'
/usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/data.rs:286: undefined reference to Fcons' /usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/data.rs:294: undefined reference to Ffset'
/usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/data.rs:292: undefined reference to Ffuncall' /usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.y54rppfya31h0vi.rcgu.o): in function remacs::data::subr_name':
/home/cbbrowne/GitStuff/remacs/rust_src/src/data.rs:331: undefined reference to build_string' /usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.1dwmoq06oofj5ott.rcgu.o): in function remacs::keyboard::posn_at_x_y::{{closure}}':
/home/cbbrowne/GitStuff/remacs/rust_src/src/keyboard.rs:92: undefined reference to window_box_left_offset' /usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.1tn7rjievkgqjie.rcgu.o): in function remacs::indent::current_column':
/home/cbbrowne/GitStuff/remacs/rust_src/src/indent.rs:24: undefined reference to current_column' /usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.1xqnas3v3yvelud5.rcgu.o): in function remacs::buffers::overlay_lists::{{closure}}::{{closure}}':
/home/cbbrowne/GitStuff/remacs/rust_src/src/buffers.rs:676: undefined reference to Fcons' /usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.2cjkz0ycvxa12t8f.rcgu.o): in function remacs::eval::progn::{{closure}}':
/home/cbbrowne/GitStuff/remacs/rust_src/src/eval.rs:117: undefined reference to eval_sub' /usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.2oz1lhgpxhulw3ac.rcgu.o): in function remacs::crypto::hash_alg':
/home/cbbrowne/GitStuff/remacs/rust_src/src/crypto/mod.rs:60: undefined reference to make_string' /usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.2oz1lhgpxhulw3ac.rcgu.o): in function remacs::crypto::_secure_hash':
/home/cbbrowne/GitStuff/remacs/rust_src/src/crypto/mod.rs:373: undefined reference to extract_data_from_object' /usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/crypto/mod.rs:376: undefined reference to make_string'
/usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/crypto/mod.rs:401: undefined reference to make_uninit_string' /usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.2oz1lhgpxhulw3ac.rcgu.o): in function remacs::crypto::buffer_hash':
/home/cbbrowne/GitStuff/remacs/rust_src/src/crypto/mod.rs:502: undefined reference to make_uninit_string' /usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.2s66ktsaf5qo96rv.rcgu.o): in function remacs::minibuf::minibufferp':
/home/cbbrowne/GitStuff/remacs/rust_src/src/minibuf.rs:(.text._ZN6remacs7minibuf11minibufferp17hf083d0dc0e03bdbbE+0xcb): undefined reference to Vminibuffer_list' /usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.2s66ktsaf5qo96rv.rcgu.o): in function remacs::minibuf::active_minibuffer_window':
/home/cbbrowne/GitStuff/remacs/rust_src/src/minibuf.rs:30: undefined reference to minibuf_level' /usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/minibuf.rs:(.text._ZN6remacs7minibuf24active_minibuffer_window17h65e9a6f6bee6a8b2E+0x2a): undefined reference to minibuf_window'
/usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.2s66ktsaf5qo96rv.rcgu.o): in function remacs::minibuf::set_minibuffer_window': /home/cbbrowne/GitStuff/remacs/rust_src/src/minibuf.rs:(.text._ZN6remacs7minibuf21set_minibuffer_window17hc87f388f8a056037E+0x37): undefined reference to minibuf_window'
/usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.2s66ktsaf5qo96rv.rcgu.o): in function remacs::minibuf::minibuffer_depth': /home/cbbrowne/GitStuff/remacs/rust_src/src/minibuf.rs:57: undefined reference to minibuf_level'
/usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.2s66ktsaf5qo96rv.rcgu.o): in function remacs::minibuf::minibuffer_prompt': /home/cbbrowne/GitStuff/remacs/rust_src/src/minibuf.rs:65: undefined reference to Fcopy_sequence'
/usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.36mw6hewk31ce7k1.rcgu.o): in function remacs::chartable::<impl remacs::lisp::ExternalPtr<remacs::remacs_sys::Lisp_Char_Table>>::get::{{closure}}': /home/cbbrowne/GitStuff/remacs/rust_src/src/chartable.rs:84: undefined reference to make_string'
/usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.3epecmtd0umddjpe.rcgu.o): in function remacs::decompress::zlib_decompress_region': /home/cbbrowne/GitStuff/remacs/rust_src/src/decompress.rs:45: undefined reference to make_string'
/usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/decompress.rs:56: undefined reference to move_gap_both' /usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/decompress.rs:60: undefined reference to buf_charpos_to_bytepos'
/usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/decompress.rs:83: undefined reference to make_gap' /usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/decompress.rs:97: undefined reference to del_range'
/usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/decompress.rs:106: undefined reference to insert_from_gap' /usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/decompress.rs:111: undefined reference to maybe_quit'
/usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/decompress.rs:118: undefined reference to del_range' /usr/bin/ld: /home/cbbrowne/GitStuff/remacs/rust_src/src/decompress.rs:125: undefined reference to buf_charpos_to_bytepos'
/usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.3x33h1ajugv5boo4.rcgu.o): in function remacs::editfns::region_limit::{{closure}}': /home/cbbrowne/GitStuff/remacs/rust_src/src/editfns.rs:116: undefined reference to make_string'
/usr/bin/ld: .././rust_src/target/debug/libremacs.a(remacs-f8aa2273ee52276d.582qonl6ddfrp3mi.rcgu.o): in function remacs::syntax::set_syntax_table': /home/cbbrowne/GitStuff/remacs/rust_src/src/syntax.rs:(.text._ZN6remacs6syntax16set_syntax_table17hb09b4e9d9d3ddf4aE+0x57): undefined reference to buffer_local_flags'

I'm hoping that this moves things forwards soon; my last successful remacs build was back in June, and I certainly have been assortedly getting bitten by changes to the rust toolchain obsolescing some code within remacs. I tried forcing a build using the 2018-03-03 nightly rust, and that's breaking somewhat similarly, with some different missing objects upon trying to build temacs.

shaleh · 2018-09-10T18:20:53Z

Use the version in rust-toolchain it actually does work. Really.

cjohansson · 2018-09-11T03:49:12Z

I was able to build this on my macOS 10.13.6 system

harryfei · 2018-09-11T04:34:45Z

@cbbrowne It's so odd, I don't have any idea about that.

Could you try to build on both the master and this branch cleanly? The results may be helpful to find the root cause.

Besides, don't override the toolchain using rustup. The make task will install the right toolchain before it starts building.

harryfei · 2018-09-11T04:39:26Z

@shaleh

Use the version in rust-toolchain it actually does work. Really.

Do you mean you can build on OSX now?

shaleh · 2018-09-11T14:23:50Z

@harryfei no, I meant they should not be trying to use any version of Rust that is not in the checked in rust_toolchain file.

shaleh · 2018-09-11T14:24:13Z

OSX does build now. But the test segfaults. So the alloc change is either incomplete or incorrect.

harryfei · 2018-09-11T14:46:21Z

@shaleh If you find the root cause, you can update this PR as you wish.

FWIW, the Travis CI shows that the tests can be run normally (except for one failed test).

Fix `make check` segfaults on mac

harryfei · 2018-09-17T13:02:00Z

@shaleh

@sbillig has fixed the macOS make check segfaults. I have merged his commits already.
See harryfei#1

sbillig · 2018-09-17T13:33:02Z

I'll admit that I'm not entirely sure yet why rand::thread_rng causes a seg fault. I'm hoping that the portable dumper lands on the emacs master branch "soon", so the unexec stuff can go away, which should clear this up for good.

https://www.reddit.com/r/emacs/comments/95vwej/pdumper_status/e3xkvt3/

shaleh · 2018-09-17T19:28:31Z

OSX still failing?

sbillig · 2018-09-17T19:36:22Z

@shaleh Are you saying that it's still failing for you? If so, could you describe where it's failing and post relevant log messages, etc here?

sbillig · 2018-09-17T23:07:04Z

Oh, I see that the travis mac build is failing. The results are the same as on the master branch ("FAILED 1/7 epg-decrypt-1"). Seems like a travis environment issue; incompatible gpg version, perhaps. Definitely not introduced by this PR, anyway.

brotzeit · 2018-09-18T10:49:27Z

@Wilfred @shaleh @db48x Merge ?

shaleh · 2018-09-18T17:40:06Z

We need a ticket to track the gpg issue.

shaleh · 2018-09-18T17:40:23Z

@harryfei thanks for helping carry this.

sbillig · 2018-09-18T19:41:53Z

Added a ticket for the gpg failure: #858

Wilfred · 2018-09-19T08:17:47Z

@harryfei Awesome, thank you!

Wilfred · 2018-09-23T22:34:05Z

@harryfei I've also made you a collaborator, so you can review/merge PRs if you wish! :)

harryfei changed the title ~~upgrade rust-toolchain to nightly-2018-09-03~~ [WIP] upgrade rust-toolchain to nightly-2018-09-03 Sep 4, 2018

shanavas786 reviewed Sep 4, 2018

View reviewed changes

rust_src/remacs-macros/lib.rs Show resolved Hide resolved

harryfei changed the title ~~[WIP] upgrade rust-toolchain to nightly-2018-09-03~~ Upgrade rust-toolchain to nightly-2018-09-03 Sep 4, 2018

shaleh reviewed Sep 4, 2018

View reviewed changes

shaleh previously requested changes Sep 4, 2018

View reviewed changes

harryfei force-pushed the toolchain branch from 80253f7 to 60408c0 Compare September 9, 2018 15:31

harryfei added 7 commits September 9, 2018 23:32

upgrade rust-toolchain to nightly-2018-09-09

b315fb3

update rustfmt.toml

6144906

fix travis-format.sh

7949d6d

format all rust files

3bf9bc1

fix lisp_fn processing in docfile.rs and build.rs

8430a12

move the comment line for allow(improper_ctypes)

7cbf36b

Get OSX building with new Alloc interface.

6ba846f

harryfei force-pushed the toolchain branch from 60408c0 to 6ba846f Compare September 9, 2018 15:33

harryfei changed the title ~~Upgrade rust-toolchain to nightly-2018-09-03~~ Upgrade rust-toolchain to nightly-2018-09-09 Sep 9, 2018

shaleh approved these changes Sep 9, 2018

View reviewed changes

sbillig and others added 3 commits September 16, 2018 20:30

Update rand crate to 0.4.3

346a216

Fix make check segfaults on mac

eb64ead

Merge pull from sbillig/toolchain

42de094

Fix `make check` segfaults on mac

shaleh merged commit 51884cd into remacs:master Sep 18, 2018

harryfei deleted the toolchain branch September 19, 2018 00:28

pdelong mentioned this pull request Sep 21, 2018

Rust bindgen compile issues with GTK #859

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade rust-toolchain to nightly-2018-09-09 #852

Upgrade rust-toolchain to nightly-2018-09-09 #852

harryfei commented Sep 4, 2018 •

edited

Loading

shaleh Sep 4, 2018

harryfei Sep 5, 2018

shaleh Sep 5, 2018

shaleh Sep 4, 2018

harryfei Sep 5, 2018

shaleh left a comment

harryfei commented Sep 5, 2018

shaleh commented Sep 5, 2018

SolarAquarion commented Sep 6, 2018

harryfei commented Sep 7, 2018 •

edited

Loading

SolarAquarion commented Sep 7, 2018 via email

harryfei commented Sep 7, 2018

harryfei commented Sep 9, 2018

shaleh commented Sep 9, 2018

shaleh left a comment

cbbrowne commented Sep 10, 2018

shaleh commented Sep 10, 2018 •

edited

Loading

cjohansson commented Sep 11, 2018

harryfei commented Sep 11, 2018

harryfei commented Sep 11, 2018

shaleh commented Sep 11, 2018

shaleh commented Sep 11, 2018

harryfei commented Sep 11, 2018 •

edited

Loading

harryfei commented Sep 17, 2018 •

edited

Loading

sbillig commented Sep 17, 2018

shaleh commented Sep 17, 2018

sbillig commented Sep 17, 2018

sbillig commented Sep 17, 2018

brotzeit commented Sep 18, 2018 •

edited

Loading

shaleh commented Sep 18, 2018

shaleh commented Sep 18, 2018

sbillig commented Sep 18, 2018

Wilfred commented Sep 19, 2018

Wilfred commented Sep 23, 2018

Upgrade rust-toolchain to nightly-2018-09-09 #852

Upgrade rust-toolchain to nightly-2018-09-09 #852

Conversation

harryfei commented Sep 4, 2018 • edited Loading

shaleh Sep 4, 2018

Choose a reason for hiding this comment

harryfei Sep 5, 2018

Choose a reason for hiding this comment

shaleh Sep 5, 2018

Choose a reason for hiding this comment

shaleh Sep 4, 2018

Choose a reason for hiding this comment

harryfei Sep 5, 2018

Choose a reason for hiding this comment

shaleh left a comment

Choose a reason for hiding this comment

harryfei commented Sep 5, 2018

shaleh commented Sep 5, 2018

SolarAquarion commented Sep 6, 2018

harryfei commented Sep 7, 2018 • edited Loading

SolarAquarion commented Sep 7, 2018 via email

harryfei commented Sep 7, 2018

harryfei commented Sep 9, 2018

shaleh commented Sep 9, 2018

shaleh left a comment

Choose a reason for hiding this comment

cbbrowne commented Sep 10, 2018

shaleh commented Sep 10, 2018 • edited Loading

cjohansson commented Sep 11, 2018

harryfei commented Sep 11, 2018

harryfei commented Sep 11, 2018

shaleh commented Sep 11, 2018

shaleh commented Sep 11, 2018

harryfei commented Sep 11, 2018 • edited Loading

harryfei commented Sep 17, 2018 • edited Loading

sbillig commented Sep 17, 2018

shaleh commented Sep 17, 2018

sbillig commented Sep 17, 2018

sbillig commented Sep 17, 2018

brotzeit commented Sep 18, 2018 • edited Loading

shaleh commented Sep 18, 2018

shaleh commented Sep 18, 2018

sbillig commented Sep 18, 2018

Wilfred commented Sep 19, 2018

Wilfred commented Sep 23, 2018

harryfei commented Sep 4, 2018 •

edited

Loading

harryfei commented Sep 7, 2018 •

edited

Loading

shaleh commented Sep 10, 2018 •

edited

Loading

harryfei commented Sep 11, 2018 •

edited

Loading

harryfei commented Sep 17, 2018 •

edited

Loading

brotzeit commented Sep 18, 2018 •

edited

Loading